-
-
Notifications
You must be signed in to change notification settings - Fork 49.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popconfirm): make title bold and add description prop #39250
Conversation
哦,发到 feature 分支吧。 |
@afc163 已squash并发到feature分支了 |
可以修改一下所有 demo,加上 description |
@afc163 已添加demos提交 |
… of demos translation)
|
@afc163 snapshot 已更新 |
table 和 space 里也要更新 |
@afc163 我走了一遍所有的test更新 |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #39250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 550 550
Lines 9431 9433 +2
Branches 2681 2683 +2
=========================================
+ Hits 9431 9433 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Popconfirm 组件新增 |
… of popconfirm md)2
components/locale-provider/__tests__/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
…st.ts.snaps and update popconfirm)
冲突了,合并一下 feature |
好的。 |
@afc163 好了 |
我这里是把远端的feature都更新,发现只有快照冲突,然后接受feature的快照,自己重新跑一边test:update |
还有一处 snapshot 未更新 |
感觉有点奇怪所有的都跑了一边,不知道还有哪出没更新,可能是本地跑着很长然后失败了 @afc163 已更 辛苦大佬多次review☺ |
components/locale-provider/__tests__/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
合并了! |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Popconfirm title and description props
💡 Background and solution
📝 Changelog
description
prop now.description
属性。☑️ Self-Check before Merge