Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): fix custom expand icon cannot be hidden #40071

Merged
merged 8 commits into from
Jan 7, 2023

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jan 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fixed #40041

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix <Menu /> custom expand icon cannot be hidden
🇨🇳 Chinese 修复 <Menu /> 自定义展开图标无法隐藏的错误

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

components/menu/menu.tsx Outdated Show resolved Hide resolved
components/menu/menu.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c2705d1) compared to base (0dc7815).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #40071   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          603       603           
  Lines        10229     10230    +1     
  Branches      2731      2731           
=========================================
+ Hits         10229     10230    +1     
Impacted Files Coverage Δ
components/menu/style/vertical.tsx 100.00% <ø> (ø)
components/menu/menu.tsx 100.00% <100.00%> (ø)
components/cascader/style/index.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wxh16144 Wxh16144 changed the title fix(menu): fix the bug that the custom expand icon is not hidden in collapse mode fix(menu): fix custom expand icon cannot be hidden Jan 7, 2023
@zombieJ
Copy link
Member

zombieJ commented Jan 7, 2023

这个还是 fix custom expand icon cannot be hidden 么?不是 className 丢失的问题么?

@Wxh16144
Copy link
Member Author

Wxh16144 commented Jan 7, 2023

这个还是 fix custom expand icon cannot be hidden 么?不是 className 丢失的问题么?

classname 丢失不是bug,这个pr还是修复 #40041

@zombieJ zombieJ merged commit 0086884 into ant-design:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu导航菜单收起状态自定义展开图标依然存在
3 participants