Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WeekPicker support hover style #40772

Merged
merged 9 commits into from
Feb 19, 2023
Merged

feat: WeekPicker support hover style #40772

merged 9 commits into from
Feb 19, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English WeekPicker support hover style.
🇨🇳 Chinese WeekPicker 支持鼠标悬浮样式。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 373.24 KB (+187 B 🔺)
./dist/antd-with-locales.min.js 429.67 KB (+213 B 🔺)

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (76192a0) compared to base (1ebdfb7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #40772   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          608       608           
  Lines        10350     10350           
  Branches      2805      2805           
=========================================
  Hits         10350     10350           
Impacted Files Coverage Δ
components/date-picker/style/index.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc
Copy link
Member

MadCcc commented Feb 17, 2023

image
这个圆角是不是可以去掉

@zombieJ
Copy link
Member Author

zombieJ commented Feb 17, 2023

高亮区域问题,改了。我到 comment 里贴一下设计稿

@afc163
Copy link
Member

afc163 commented Feb 17, 2023

图片

单选样式没了。

@zombieJ zombieJ merged commit 1081296 into feature Feb 19, 2023
@zombieJ zombieJ deleted the week-picker branch February 19, 2023 04:33
@afc163
Copy link
Member

afc163 commented Feb 19, 2023

还是不对,原来的 hover 背景色是灰的。

图片

现在变成高亮的了。

图片

@MadCcc MadCcc mentioned this pull request Mar 5, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* feat: support range hover style

* chore: adjust hover style

* chore: cleanup

* chore: update style

* test: update snapshot

* chore: fix style

* chore: cleanup

* chore: cleanup
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: support range hover style

* chore: adjust hover style

* chore: cleanup

* chore: update style

* test: update snapshot

* chore: fix style

* chore: cleanup

* chore: cleanup
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: support range hover style

* chore: adjust hover style

* chore: cleanup

* chore: update style

* test: update snapshot

* chore: fix style

* chore: cleanup

* chore: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants