Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): Focus outline being blocked by other elements #41282

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Mar 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #41175

💡 Background and solution

当前在 Space.Compact 内的按钮,使用 Tab 聚焦的话,聚焦轮廓会被其他元素遮挡 。下图为修改前后对比。
修改前:
image

修改后:
image

📝 Changelog

Language Changelog
🇺🇸 English Fixed dropdown button focus outline being blocked by other elements
🇨🇳 Chinese 修复下拉按钮的聚焦轮廓被其他元素遮挡

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (39adae8) 100.00% compared to head (15e19aa) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10494     10450   -44     
  Branches      2868      2847   -21     
=========================================
- Hits         10494     10450   -44     
Impacted Files Coverage Δ
components/button/style/index.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 6c02a0e into ant-design:master Mar 17, 2023
trongtai37 pushed a commit to trongtai37/ant-design that referenced this pull request Mar 18, 2023
@PeachScript PeachScript mentioned this pull request Mar 20, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus treatment issue for button with dropdown
3 participants