✨ feat: remove tag border in Select、Tree-select、Cascader #41480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
size-limit report 📦
|
components/form/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
components/space/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #41480 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 614 614
Lines 10503 10505 +2
Branches 2877 2877
=========================================
+ Hits 10503 10505 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
components/form/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
components/space/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
MadCcc
reviewed
Mar 27, 2023
li-jia-nan
changed the title
li-jia-nan
changed the title
|
原始问题和需求是什么？ |
|
设计有需求把 Select 的多选 Tag 替换为无边框的。 |
|
|
这个先等一下，闲夕大佬说对 |
li-jia-nan
changed the title
li-jia-nan
changed the title
li-jia-nan
changed the title
MadCcc
reviewed
Apr 6, 2023
MadCcc
reviewed
Apr 6, 2023
MadCcc
reviewed
Apr 6, 2023
Co-authored-by: MadCcc <[email protected]>
MadCcc
approved these changes
Apr 7, 2023
li-jia-nan
changed the title
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* ✨ feat: new tag * update demo * update snap * fix * fix * fix * fix * fix * fix * fix style * update snap * revert * fix * fix * fix * fix * fix * Update components/select/style/multiple.tsx Co-authored-by: MadCcc <[email protected]> --------- Co-authored-by: MadCcc <[email protected]>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* ✨ feat: new tag * update demo * update snap * fix * fix * fix * fix * fix * fix * fix style * update snap * revert * fix * fix * fix * fix * fix * Update components/select/style/multiple.tsx Co-authored-by: MadCcc <[email protected]> --------- Co-authored-by: MadCcc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
设计有需求把 Select、Tree-select、Cascader 的多选 Tag 替换为无边框的。
同时因为样式和 antd 的 Tag 基本一致，所以尝试下直接替换，从设计角度上可以保证一致性，antd 侧也可以少加点样式。
📝 Changelog
☑️ Self-Check before Merge