Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove fixed height in badge.ribbon #41661

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

MuxinFeng
Copy link
Contributor

@MuxinFeng MuxinFeng commented Apr 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

relate #41653

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English remove fixed height in badge.ribbon
🇨🇳 Chinese 去除 badge.ribbon 里固定的高度

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 6598f36

Remove height from badge style to fix alignment bug. This change affects the badge component and its style file components/badge/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 6598f36

  • Remove height property from shared badge style to fix badge alignment bug (link)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (912d393) 100.00% compared to head (18a3ca5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41661   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          614       614           
  Lines        10497     10497           
  Branches      2874      2874           
=========================================
  Hits         10497     10497           
Impacted Files Coverage Δ
components/badge/style/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ
Copy link
Member

zombieJ commented Apr 6, 2023

最好 Demo 加个,这样好 CI 对比掉~

@zombieJ zombieJ merged commit fc24f38 into ant-design:master Apr 6, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* style: remove fixed height in badge.ribbon

* docs: update demo

* test: update snapshot
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* style: remove fixed height in badge.ribbon

* docs: update demo

* test: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants