Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate less to token for Rate #42135

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

MuxinFeng
Copy link
Contributor

@MuxinFeng MuxinFeng commented May 4, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#41884

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English migrate less to token for Rate
🇨🇳 Chinese 迁移 Rate 组件的 less token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 52f63a9

Refactored the Rate component style hook and updated the migration guide for less variables. This improves the code quality and the user experience of customizing the Rate component.

🔍 Walkthrough

🤖 Generated by Copilot at 52f63a9

  • Refactor Rate component to use genComponentStyleHook with default token (link,link)
  • Add documentation for Rate component token mapping in migration guide for less variables (link,link)

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

@MuxinFeng MuxinFeng changed the base branch from master to feature May 4, 2023 10:04
@yoyo837 yoyo837 mentioned this pull request May 4, 2023
51 tasks
@socket-security
Copy link

socket-security bot commented May 4, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No dependency changes detected in pull request

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

| less 变量 | Component Token | 备注 |
| --- | --- | --- |
| `@rate-star-color` | `rateStarColor` | - |
| `@rate-star-bg` | - | 由于样式变化已废弃 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个就是 defaultColor 了,可以吧 defaultColor 改个名

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (24dd535) 100.00% compared to head (2ef7ef4) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           feature    #42135    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          619       640    +21     
  Lines        11048     10843   -205     
  Branches      3081      2945   -136     
==========================================
- Hits         11048     10843   -205     
Impacted Files Coverage Δ
components/auto-complete/index.tsx 100.00% <ø> (ø)
components/config-provider/context.ts 100.00% <ø> (ø)
components/divider/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
components/locale/en_US.ts 100.00% <ø> (ø)
components/locale/index.tsx 100.00% <ø> (ø)
components/locale/zh_CN.ts 100.00% <ø> (ø)
components/menu/MenuItem.tsx 100.00% <ø> (ø)
components/menu/hooks/useItems.tsx 100.00% <ø> (ø)
... and 61 more

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc
Copy link
Member

MadCcc commented May 17, 2023

补一个 debug demo 哈

@MadCcc MadCcc merged commit 0ea9c88 into ant-design:feature May 18, 2023
@MadCcc MadCcc mentioned this pull request Jun 6, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants