Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add active style #42249

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: add active style #42249

merged 1 commit into from
May 10, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented May 10, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: add active style
🇨🇳 Chinese fix: 增加鼠标 active 的样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 9bdb4d2

Added a new feature and a style enhancement to the segmented component. The new fill prop allows users to customize the color scheme, and the active state style gives visual feedback on the selected item.

🔍 Walkthrough

🤖 Generated by Copilot at 9bdb4d2

  • Add bgColorActive property to SegmentedToken interface and item style to define the background color of the segmented item when pressed (link, link)
  • Add fill prop to segmented component and colorFill variable to useSegmentedStyle hook to allow different color schemes for the component (link, link)
  • Reorder import statements to group and separate type and value imports (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 376.4 KB (+26 B 🔺)
./dist/antd-with-locales.min.js 435.67 KB (+28 B 🔺)

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7de7a8b) 100.00% compared to head (9bdb4d2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          618       618           
  Lines        10539     10573   +34     
  Branches      2879      2896   +17     
=========================================
+ Hits         10539     10573   +34     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 026b74a into master May 10, 2023
@afc163 afc163 deleted the segmented branch May 10, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants