fix: qrcode fgColor for dark mode #43162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 648
Lines 10963 10963
Branches 2976 2976
=========================================
Hits 10963 10963
☔ View full report in Codecov by Sentry. |
afc163
approved these changes
Jun 24, 2023
|
li-jia-nan
reviewed
Jun 24, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
QRCode remains black in dark theme.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 00d333f
Improved the QRCode component's color handling. Made it possible to omit the
colorprop and use the theme's text color instead.🔍 Walkthrough
🤖 Generated by Copilot at 00d333f
colorprop of the QRCode component optional and use the theme token colorText as the default foreground color of the QR code (link, link)fgColoroption of the QRCodeGenerator to respect thecolorprop or the theme token colorText (link)