Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: replace unknown with TooltipRef #43452

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Jul 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English type: replace unknown with TooltipRef
🇨🇳 Chinese 替换unknown 成 TooltipRef

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 97bf08b

Refactored Popconfirm component to use TooltipRef type and forward ref. This improves compatibility and reusability with Tooltip component.

🔍 Walkthrough

🤖 Generated by Copilot at 97bf08b

  • Import and use TooltipRef type for Popconfirm component (link, link)

@stackblitz
Copy link

stackblitz bot commented Jul 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

@li-jia-nan
Copy link
Member

PR body 要保留默认格式,有需要补充的信息可以填在里面,但是默认格式不要删掉

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2cb72a7) 100.00% compared to head (97bf08b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43452   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10968     10968           
  Branches      2978      2978           
=========================================
  Hits         10968     10968           
Impacted Files Coverage Δ
components/popconfirm/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan merged commit 56e6102 into ant-design:master Jul 8, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants