Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master into feature #43940

Merged
merged 16 commits into from
Aug 2, 2023
Merged

chore: merge master into feature #43940

merged 16 commits into from
Aug 2, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Aug 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 61176f5

This pull request introduces several code quality improvements, bug fixes, and new features for the antd library and its documentation site. It adds support for code sandbox rendering with sandpack in the dumi theme, fixes a scrolling issue with the Anchor component, updates the test cases and the changelog for the 5.8.0 release, and annotates some style objects with React.CSSProperties type. It also modifies some style and import statements for readability and performance.

🔍 Walkthrough

🤖 Generated by Copilot at 61176f5

  • Add changelog for 5.8.0 version in English and Chinese (link, link)
  • Customize Sandpack component with dumi and antd features and styles (link, link, link, link)
  • Replace SourceCode node with lang property equal to sandpack with Sandpack node in rehypeAntd function (link, link, link)
  • Remove unnecessary as any casts from mergedData, token, and gray objects (link, link, link)
  • Import CloseOutlined icon as default import to enable tree shaking (link)
  • Remove redundant conditional branch for getCurrentAnchor function and fix potential bug in Anchor component (link, link, link)
  • Modify test case and add new test case for Anchor component to reflect changes (link, link)
  • Annotate style objects with React.CSSProperties type in various demo components (link, link, link, link, link, link, link, link)
  • Replace template literals with plain strings for left and top properties of holder style object in WaveEffect component (link)
  • Change import order of some modules in GlobalLayout component to follow convention (link)
  • Increase height of iframe for component-token.tsx code example in anchor documentation (link, link)

yee94 and others added 8 commits July 31, 2023 13:22
…43875)

* fix: the number input radius style in different size

* fix: make style token as a function

---------

Co-authored-by: yee.wang <[email protected]>
Co-authored-by: afc163 <[email protected]>
* type(list): optimize triggerPaginationEvent type

* fix

* fix

* fix

* Update components/list/index.tsx

Signed-off-by: lijianan <[email protected]>

---------

Signed-off-by: lijianan <[email protected]>
Co-authored-by: afc163 <[email protected]>
Co-authored-by: lijianan <[email protected]>
* docs: update doc

* fix: getCurrentLink not trigger when scroll
chore: master merge feature
which reduces @ant-design/icons bundle size on nextJS 13.
* docs: use sandpack for demo

* chore: update

* docs: adjust theme

* docs: sandpack ssr

* docs: sandpack fallback

* fix: ssr

* chore: fix css extract

* chore: fix lint

* fix: fix lint

* chore: rm theme

* fix: solve ssr sissue

* chore: fix lint

---------

Signed-off-by: lijianan <[email protected]>
Co-authored-by: lijianan <[email protected]>
Co-authored-by: MadCcc <[email protected]>
Co-authored-by: kiner-tang(文辉) <[email protected]>
Co-authored-by: afc163 <[email protected]>
@stackblitz
Copy link

stackblitz bot commented Aug 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Hi @li-jia-nan

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 385.52 KB (+228 B 🔺)
./dist/antd-with-locales.min.js 444.92 KB (+215 B 🔺)

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@codesandbox/sandpack-react 2.6.9 eval, network, filesystem +32 73.8 MB danilowoz

🚮 Removed packages: [email protected]

@argos-ci
Copy link

argos-ci bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 2, 2023, 9:11 AM

* test: update snap

* chore: bump icons

---------

Co-authored-by: 二货机器人 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8a16594) 100.00% compared to head (6ca1b6d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43940   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11238     11166   -72     
  Branches      3064      3024   -40     
=========================================
- Hits         11238     11166   -72     
Files Changed Coverage Δ
components/_util/hooks/useClosable.tsx 100.00% <ø> (ø)
components/anchor/Anchor.tsx 100.00% <ø> (ø)
components/modal/Modal.tsx 100.00% <ø> (ø)
components/qr-code/index.tsx 100.00% <ø> (ø)
components/theme/index.ts 100.00% <ø> (ø)
components/_util/wave/WaveEffect.tsx 100.00% <100.00%> (ø)
components/cascader/index.tsx 100.00% <100.00%> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/input-number/style/index.ts 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MadCcc and others added 6 commits August 2, 2023 10:54
* docs: update v5.8.0 changelog

* Update CHANGELOG.zh-CN.md

Co-authored-by: afc163 <[email protected]>
Signed-off-by: vagusX <[email protected]>

* Update CHANGELOG.en-US.md

Signed-off-by: vagusX <[email protected]>

* docs: update

---------

Signed-off-by: vagusX <[email protected]>
Co-authored-by: afc163 <[email protected]>
* test: init of test

* test: update snapshot

* test: update snapshot

* chore: adjust size limit

* test: update snapshot

* test: update snapshot

* test: update snapshot

* chore: update snapshot

---------

Co-authored-by: lijianan <[email protected]>
* feat: clearIcon

* feat: clearIcon

* Update components/select/utils/iconUtil.tsx

Co-authored-by: afc163 <[email protected]>
Signed-off-by: kiner-tang(文辉) <[email protected]>

* feat: clearIcon

* chore: raise size-limit

---------

Signed-off-by: kiner-tang(文辉) <[email protected]>
Co-authored-by: afc163 <[email protected]>
Co-authored-by: MadCcc <[email protected]>
* chore: update snapshot

* chore
@yoyo837
Copy link
Contributor

yoyo837 commented Aug 2, 2023

要不要挂WIP? 发完5.8.1一次性搞定怎样?

@li-jia-nan
Copy link
Member Author

都可以,听yoyo哥的

@yoyo837 yoyo837 marked this pull request as draft August 2, 2023 07:50
* docs: changelog 5.8.1

* Apply suggestions from code review

Signed-off-by: MadCcc <[email protected]>

---------

Signed-off-by: MadCcc <[email protected]>
@li-jia-nan li-jia-nan marked this pull request as ready for review August 2, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants