Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: rewrite render function with React.FC #50779

Merged
merged 5 commits into from
Sep 10, 2024
Merged

demo: rewrite render function with React.FC #50779

merged 5 commits into from
Sep 10, 2024

Conversation

li-jia-nan
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English demo: rewrite render function with React.FC
🇨🇳 Chinese demo: rewrite render function with React.FC

Copy link

stackblitz bot commented Sep 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Sep 10, 2024

👁 Visual Regression Report for PR #50779 Failed ❌

🎯 Target branch: feature (fbf8b10)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
splitter-collapsible.compact.png splitter-collapsible.compact.png splitter-collapsible.compact.png splitter-collapsible.compact.png
splitter-collapsible.compact.png splitter-collapsible.compact.png splitter-collapsible.compact.css-var.png splitter-collapsible.compact.css-var.png
splitter-collapsible.dark.png splitter-collapsible.dark.png splitter-collapsible.dark.png splitter-collapsible.dark.png
splitter-collapsible.dark.png splitter-collapsible.dark.png splitter-collapsible.dark.css-var.png splitter-collapsible.dark.css-var.png
splitter-collapsible.default.png splitter-collapsible.default.png splitter-collapsible.default.png splitter-collapsible.default.png
splitter-collapsible.default.png splitter-collapsible.default.png splitter-collapsible.default.css-var.png splitter-collapsible.default.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Sep 10, 2024

size-limit report 📦

Path Size
dist/antd.min.js 439.12 KB (-5 B 🔽)
dist/antd-with-locales.min.js 505.83 KB (-6 B 🔽)

Copy link

pkg-pr-new bot commented Sep 10, 2024

Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ade18c
Status: ✅  Deploy successful!
Preview URL: https://e82eae4c.ant-design.pages.dev
Branch Preview URL: https://demo-up.ant-design.pages.dev

View logs

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fbf8b10) to head (1ade18c).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #50779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          761       761           
  Lines        13473     13473           
  Branches      3503      3503           
=========================================
  Hits         13473     13473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 01d1b3d into feature Sep 10, 2024
60 checks passed
@li-jia-nan li-jia-nan deleted the demo-up branch September 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants