Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(Descriptions): style bordered table overflow" #50891

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 17, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

Reverts #49946

close #50848

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Revert #49946 to fix the issue where the popup layer component inside Descriptions is being cut off.
🇨🇳 Chinese 回滚 #49946 以修复 Descriptions 内弹层组件被截断的问题。

Copy link

stackblitz bot commented Sep 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Sep 17, 2024

👁 Visual Regression Report for PR #50891 Failed ❌

🎯 Target branch: master (95756c2)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.png
descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.css-var.png descriptions-component-token.compact.css-var.png
descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.png
descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.css-var.png descriptions-component-token.dark.css-var.png
descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.png
descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.css-var.png descriptions-component-token.default.css-var.png
descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.png
descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.css-var.png descriptions-style.compact.css-var.png
descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.png
descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.css-var.png descriptions-style.dark.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 433.5 KB (-1 B 🔽)
dist/antd-with-locales.min.js 501.07 KB (-2 B 🔽)

Copy link

pkg-pr-new bot commented Sep 17, 2024

@li-jia-nan
Copy link
Member

留个 test 快照吗大佬?

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95756c2) to head (ac8fa5d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #50891   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          752       752           
  Lines        13172     13172           
  Branches      3425      3425           
=========================================
  Hits         13172     13172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac8fa5d
Status: ✅  Deploy successful!
Preview URL: https://2da351e6.ant-design.pages.dev
Branch Preview URL: https://revert-49946-hotfix-descript.ant-design.pages.dev

View logs

@li-jia-nan
Copy link
Member

哦,好像已经有了,不用留了

@afc163 afc163 merged commit ef10661 into master Sep 17, 2024
66 checks passed
@afc163 afc163 deleted the revert-49946-hotfix/description-style branch September 17, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select 设置 getPopupContainer 挂载到父级元素,且在 Descriptions 中时,下拉列表显示异常
2 participants