Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复Modal样式 #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RyanLiu0235
Copy link

@RyanLiu0235 RyanLiu0235 commented Jan 10, 2020

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.

@RyanLiu0235
Copy link
Author

  1. Modal的展示与否既然是靠样式的display: none;而非a:if来确定,就要让这个操作是最高层级的,否则如果外面有对view设置额外样式,就可能导致Modal无法隐藏。
  2. Modal目前没有自动在屏幕水平垂直居中,我实在想不出有什么场景需要这样处理,姑且认为是一个bug吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant