upgrade to libsecp256k1 v0.5.0; improves k1 signing performance ~10% #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
May 15, 2024
| ECMULT_GEN_PREC_BITS=4 | ||
| ENABLE_MODULE_EXTRAKEYS=1 | ||
| COMB_BLOCKS=11 | ||
| COMB_TEETH=6 |
There was a problem hiding this comment.
These changes are snooped out via
https://github.com/bitcoin-core/secp256k1/blob/e3a885d42a7800c1ccebad94ad1e2b82c4df5c65/CMakeLists.txt#L104-L119
I needed to add ENABLE_MODULE_EXTRAKEYS to get the tests to compile. That might be an oversight in the upstream project (MODULE_EXTRAKEYS is required by MODULE_SCHNORRSIG -- both enabled by default in default config -- so it may be uncommon to compile without MODULE_EXTRAKEYS). Doesn't really matter though: just some tiny bit of unused-by-spring code added.
heifner
approved these changes
May 15, 2024
linh2931
approved these changes
May 15, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for another awesome libsecp256k1 update. v0.5.0 improves signing performance by about ~10% in my tests. The improvement is via
https://github.com/bitcoin-core/secp256k1/pull/1058