Avoid voting until caught up with network #262
Conversation
| if (!enable_voting) { // Avoid extra processing while syncing. Once caught up, consider voting | ||
| if (bsp->timestamp() < fc::time_point::now() - fc::seconds(30)) | ||
| return; | ||
| enable_voting = true; | ||
| } |
There was a problem hiding this comment.
move before line 97 to avoid extra memory allocation+free when syncing
There was a problem hiding this comment.
The enable_voting is protected by the mutex.
- Could make it atomic
- Could move the
.reserve()call after and inside the mutex lock - Could leave it as is
Not clear to me which is better. Maybe atomic.
There was a problem hiding this comment.
Yes, I think atomic may be best. Even without atomic, it seems that the worse that could happen is for a couple extra votes to go though.
There was a problem hiding this comment.
or move the reserve within the mutex protection, even simpler imo.
There was a problem hiding this comment.
Maybe even better would be to do this check on the main thread before we call consider_voting(bsp, use_thread_pool_t::yes);, so we don't post unneeded tasks on the thread pool.
Do not post to thread pool while syncing/replaying
|
Note:start |
Resolves #259