Add signed integer types as implementors of the nonzeroable traits #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the stable additions from a few releases ago.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 14, 2019
7: Add signed integer types as implementors of the nonzeroable traits r=antifuchs a=antifuchs Co-authored-by: Andreas Fuchs <[email protected]>
Timed out |
Since casting negative numbers to usize seems really wrong (and it triggers rust-lang/rust#67539 on nightlies). Let's use .count_ones() to get a guarantee that the number we have is non-zero instead.
* Allow main in doctests, we need them for no_std. * Add a Safety section to as_nonzero_unchecked.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2019
7: Add signed integer types as implementors of the nonzeroable traits r=antifuchs a=antifuchs Co-authored-by: Andreas Fuchs <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.