Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipper can not replay saved file .... #14

Open
DavidIgor opened this issue Jun 5, 2023 · 16 comments
Open

Flipper can not replay saved file .... #14

DavidIgor opened this issue Jun 5, 2023 · 16 comments

Comments

@DavidIgor
Copy link

Hi , it looks like modulation issue ?

@DavidIgor
Copy link
Author

it just display : "cannot parse file "

@ErSeraph
Copy link

ErSeraph commented Jun 6, 2023

I found a potential fix, but cannot try it right now, but you can open the raw file now:

If you edit your file on notepad you will see that "Protocol: RAW" is not escaped, and some other code is escaped and it's not needed.

Example, before the edit:
Filetype: Flipper SubGhz RAW File
Version: 1
Frequency: 433920000
Preset: FuriHalSubGhzPresetCustom
Custom_preset_module: CC1101
Custom_preset_data: 02 0D 0B 06 08 32 07 04 14 00 13 02 12 04 11 93 10
6A 15 41 18 18 19 16 1D 91 1C 00 1B 07 20 FB 22 10 21 56 Protocol: RAW
RAW_Data: ........

After the edit:
Filetype: Flipper SubGhz RAW File
Version: 1
Frequency: 433920000
Preset: FuriHalSubGhzPresetCustom
Custom_preset_module: CC1101
Custom_preset_data: 02 0D 0B 06 08 32 07 04 14 00 13 02 12 04 11 93 10 6A 15 41 18 18 19 16 1D 91 1C 00 1B 07 20 FB 22 10 21 56
Protocol: RAW
RAW_Data: .........

Focus on "Custom_preset_data" and "Protocol: RAW", I managed to read the file with the Flipper, you can open it but i didn't tried it yet

@DavidIgor
Copy link
Author

yes , it worked ! I added also custom modulations in setup file (according to custom preset data) , however when I create tpms signal in app it wont do anything .... any suggestions? I use sensor ID from my read with protoview app.

@DavidIgor
Copy link
Author

I have recorder low pressure warning from my wheel (recorded on HackRF) when I reply it with HackRF it brings warning light on dashboard of my car. tested to capture and save with protoview app ....it captures it correctly as renault tpms with low pressure , but replaying it with app wont do anything .... nothing happen even if I replay saved file.

@ErSeraph
Copy link

ErSeraph commented Jun 7, 2023

Me too, file fixed but cannot replay correctly

@DavidIgor
Copy link
Author

I want it to work! hhh
noticed strange thing with sensor IDs as hackrf reads different than protoview ... not sure which is correct ... I will have to investigate

@thedroidgeek
Copy link

thedroidgeek commented Jun 9, 2023

There's 2 bugs in the capture file generation code for custom modulations, which cause the resulting custom preset data line to lack PATABLE bytes and a line feed.

You can try manually adding 00 00 C0 00 00 00 00 00 00 00 at the end of the preset data line to make it work.

I might make a pull request if I get around to fixing the code in a clean way.

thedroidgeek added a commit to thedroidgeek/protoview that referenced this issue Jun 9, 2023
Fix the incomplete custom preset data and the line feed in the wrong location for the signal file generation code.
@DavidIgor
Copy link
Author

@thedroidgeek like this? and also creating new custom modulation in settings file?

Filetype: Flipper SubGhz RAW File
Version: 1
Frequency: 433920000
Preset: FuriHalSubGhzPresetCustom
Custom_preset_module: CC1101
Custom_preset_data: 02 0D 0B 06 08 32 07 04 14 00 13 02 12 04 11 93 10 6A 15 41 18 18 19 16 1D 91 1C 00 1B 07 20 FB 22 10 21 56 00 00 C0 00 00 00 00 00 00 00
Protocol: RAW
RAW_Data: .........

@thedroidgeek
Copy link

Yes, but there's no need to modify the settings file.

@DavidIgor
Copy link
Author

@thedroidgeek ok copy that! but It may allow me to use modulation outside of protoview ...right?

@thedroidgeek
Copy link

Could you stop asking pointless questions and try to use some common sense?
Why the hell would we have to include preset data in the capture file if it's not to avoid having to add it in the settings file also?

@antirez
Copy link
Owner

antirez commented Jun 10, 2023

I had the lack of PTABLE somewhere noted in a private TODO file. Then got trapped in the LoRa things and forgot to fix it.

@DavidIgor
Copy link
Author

@ErSeraph there is also end part of the modulation that is missing in sub file as per @thedroidgeek comment. Note: still nothing happens when replying saved or created file .
I did added said modulation to my settings file and recorded raw signal but even this way it won't work.

@DavidIgor
Copy link
Author

@thedroidgeek sorry for misunderstanding I was just trying to make it work outside of the app.

@thedroidgeek
Copy link

@DavidIgor No I'm the one that should apologize, sorry for my tone. You seem to own a HackRF though, so you should be able to debug and figure out how to fix stuff yourself. Universal Radio Hacker is a useful tool for decoding data to make sure you're transmitting the right stuff. Good luck.

@antirez Well done on the app, I appreciate people like you that thoroughly document their work. I've already submitted a PR for this fix ICYMI.

@DavidIgor
Copy link
Author

@thedroidgeek all good, I do own hackrf with portapack but only for month or so ... lot to learn ! URH is great thanks for tip.
Im currently using TPMS app with portapack and protoview in flipper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants