Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #163 - tokens with backslashes #164

Closed
wants to merge 3 commits into from

Conversation

robstoll
Copy link
Contributor

Fixes #163 - fixed token file generation for tokens with backslashes in their corresponding literal part

@sharwell
Copy link
Member

Can you also add a regression test? I want to make sure that it not only parses, but is recognizing the correct sequence of input characters as a token.

@robstoll
Copy link
Contributor Author

Sure. Could you please point out where I should add the test? I could not find (quickly) a test relating to .tokens file generation.

@sharwell
Copy link
Member

Probably in TestJavaCodeGeneration.java.

@robstoll
Copy link
Contributor Author

Thanks for the quick answer, I must have overlooked this file. I will create a test in the coming days.

@robstoll
Copy link
Contributor Author

Found some time to write the tests. Please let me know if these regression tests should not be enough

@sharwell
Copy link
Member

This is not a valid change. See #163 for details.

@robstoll
Copy link
Contributor Author

You should at least merge the regression test

testTokenVocabWithUnescapedBackslashThrowsNullPointerException

And you will see that the current implementation is wrong. I am happy if you fix it otherwise but it is still a bug IMO

@sharwell
Copy link
Member

The error is a duplicate of #157

@robstoll
Copy link
Contributor Author

Fair enough, I figured that are two different things. Anyway, I am looking forward to the merge of your pull request #165 and will see if it works for me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokens with backslashes need to be escaped in tokens file
2 participants