Fix listener example in C++ documentation. #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listener example still refers to
Ref<>
and shared pointers, but inreality the generated method does not pass a shared pointer. The actual
signature looks more like this:
This change updates the example to match that signature, and removes a line
discussing
Ref<>
. It also adds theoverride
keyword in order to make theuser's code a little more robust against typos/changes in the grammar.