Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Small optimizations #1907

Merged
merged 4 commits into from
Jun 11, 2017
Merged

[C++] Small optimizations #1907

merged 4 commits into from
Jun 11, 2017

Conversation

mike-lischke
Copy link
Member

Found a better way to manage s0 in the DFA if set from outside. And a few other small changes.

@parrt parrt added this to the 4.7.1 milestone Jun 11, 2017
@parrt parrt merged commit 35cf1ba into antlr:master Jun 11, 2017
@jm-mikkelsen
Copy link
Contributor

jm-mikkelsen commented Jun 12, 2017

The change to Cpp.stg, removing the "antlr4::" qualifier on RuleContext, breaks unit tests for me. Tests with that change reverted running now, but passed all the tests that failed earlier. Example:

In file included from /tmp/BaseCppTest-main-1497246422711/L.cpp:5:
/tmp/BaseCppTest-main-1497246422711/L.h:52:17: error: unknown type name 'RuleContext'; did you mean 'antlr4::RuleContext'?
bool TSempred(RuleContext *_localctx, size_t predicateIndex);
^~~~~~~~~~~
antlr4::RuleContext
/home/janm/p4/amt5-io/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/RuleContext.h:62:26: note: 'antlr4::RuleContext' declared here
class ANTLR4CPP_PUBLIC RuleContext : public tree::ParseTree {
^
1 error generated.

@mike-lischke
Copy link
Member Author

A pity that the Travis test constantly time out. That way you never see if you break the build. Thanks @jm-mikkelsen, I'll open a new PR to revert that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants