Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input mismatch errors not reported the same way as Java in Python #1921

Merged
merged 4 commits into from
Jun 25, 2017

Conversation

alimg
Copy link
Contributor

@alimg alimg commented Jun 19, 2017

I'm getting different error messages from Java and Python runtimes for the same grammar. Figured out a check from the Java version was missing in the Python one so here's it

@ericvergnaud
Copy link
Contributor

Hi,
while you're at it, and since you have a grammar to reproduce the issue, could you add a test case in:
runtime-testsuite/test/org/antlr/v4/test/runtime/descriptors/ParserErrorsDescriptors.java
Eric

@alimg
Copy link
Contributor Author

alimg commented Jun 20, 2017

Hi Eric,
Added a test case which can reproduce the issue. Looks like we didn't notice before since the problems occurs when there are more terminal symbols defined.

@ericvergnaud
Copy link
Contributor

Great!
Not sure what's wrong with the cpp tests, but clearly unrelated to this.
@parrt blessed

@parrt
Copy link
Member

parrt commented Jun 25, 2017

@alimg you need to sign contributors.txt

@parrt parrt added this to the 4.7.1 milestone Jun 25, 2017
@alimg
Copy link
Contributor Author

alimg commented Jun 25, 2017

@parrt updated

@parrt parrt merged commit ff13553 into antlr:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants