Fix ParseTreePatternMatcher.split in the Swift runtime. #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanmellor
force-pushed
the
swift-fix-parsetreepatternmatcher
branch
from
217ae12
to
ba6c054
Compare
Fix the parsing inside ParseTreePatternMatcher.split. It was trivially broken in a number of ways, with bugs that aren't in the Java version that it was ported from, so it's obviously never been run before. This adds unit tests for ParseTreePatternMatcher.split, and makes Chunk implement Equatable, so that it we can compare Chunk instances in the tests. Tidy up the description implementations at the same time.
ewanmellor
force-pushed
the
swift-fix-parsetreepatternmatcher
branch
from
ba6c054
to
fd8fd17
Compare
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing inside ParseTreePatternMatcher.split. It was trivially
broken in a number of ways, with bugs that aren't in the Java version
that it was ported from, so it's obviously never been run before.
This adds unit tests for ParseTreePatternMatcher.split, and makes Chunk
implement Equatable, so that it we can compare Chunk instances in the
tests.
Tidy up the description implementations at the same time.