Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Replace IntervalSet.setReadonly with makeReadonly. #2113

Merged
merged 1 commit into from
Nov 29, 2017

Commits on Nov 9, 2017

  1. [Swift] Replace IntervalSet.setReadonly with makeReadonly.

    Replace IntervalSet.setReadonly(Bool) with makeReadonly().  This
    operation only ever works in one direction, and would throw an exception
    if a caller attempted to make a read-only IntervalSet read-write again.
    By changing the interface we remove the need to check this, and so we
    don't need to declare the exception.  Unlike in the Java runtime, we
    need to declare the possibility of the exception at the callsite, so this
    was pointlessly cluttering.
    ewanmellor committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    afdfb56 View commit details
    Browse the repository at this point in the history