[Swift] Some minor tidyups. #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanmellor
force-pushed
the
swift-minor-tidups
branch
2 times, most recently
from
8a48a8c
to
b51def4
Compare
Change the initializer to ANTLRFileStream so that it throws any errors that occur while reading the file. Previously, it was just dropping any errors on the floor (inside Utils.readFile). Remove Utils.readFile, it's not used anywhere else.
ewanmellor
force-pushed
the
swift-minor-tidups
branch
from
b51def4
to
5d7e41f
Compare
Minor tidyups in the Swift runtime. No semantic change.
Remove pointless do block from LexerATNSimulator. This is a translation from Java of a try/finally block, but we have the finally clause in a defer block so we don't need the do block.
ewanmellor
force-pushed
the
swift-minor-tidups
branch
from
5d7e41f
to
6cc35ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tidyups in the Swift runtime. No semantic change.
Depends on PR #2102 due to merge conflicts.