Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Antlr 4.13.2 is a breaking change #4254

Open
kaby76 opened this issue Sep 22, 2024 · 0 comments
Open

[build] Antlr 4.13.2 is a breaking change #4254

kaby76 opened this issue Sep 22, 2024 · 0 comments

Comments

@kaby76
Copy link
Contributor

kaby76 commented Sep 22, 2024

Antlr 4.13.2 for JavaScript is a breaking change for testing. This is because the API has changed. #4242 (comment) All output from the tester is captured--including the new deprecated warning. If there is any output that is not expected, the test fails.

For now, the version must be set to 4.13.2 for JavaScript because a PR requires the change.#4242

In addition, since this might happen again, I will need to implement per-grammar, per-version testing.

I will need to test every grammar, every target and verify that all is working. (I had done over half for #4243, but will need to redo everything, which will take several days of CPU time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant