Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TypeScript target and some modifications #4242

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

RobEin
Copy link
Contributor

@RobEin RobEin commented Sep 15, 2024

  • added TypeScript target
  • update to ANTLR 4.13.2
  • update to Python 3.12.6

@kaby76
Copy link
Contributor

kaby76 commented Sep 16, 2024

typescript-collections is not in the project.json for testing. I'll add it as a default with #4243.

@kaby76
Copy link
Contributor

kaby76 commented Sep 17, 2024

update to ANTLR 4.13.2. Could you describe which targets require 4.13.2 here? There is no version 4.13.2 for the CSharp target.

@RobEin
Copy link
Contributor Author

RobEin commented Sep 17, 2024

The following four parsers require ANTLR 4.13.2:

  • JavaScript target for Python 2.7.18 (because of depricated Recognizer.getErrorListenerDispatch(): #4562)
  • TypeScript target for Python 2.7.18 (because of depricated Recognizer.getErrorListenerDispatch(): #4562)
  • JavaScript target for Python 3.12.6 (because of depricated features: #4562)
  • TypeScript target for Python 3.12.6 (because of depricated and new features: #4562)

@kaby76
Copy link
Contributor

kaby76 commented Sep 22, 2024

Now I understand. The JavaScript port requires Antlr 4.13.2 because this PR uses the API Lexer.setMode(). Unfortunately, the build locks all grammars that have a JavaScript port at 4.13.2. So, the old API mode() outputs a deprecation warning, which is a breaking change--all output from the tester is captured and compared. I don't think there are many JS ports that use the old API, but I will need add per-grammar, per-version testing when specified in the desc.xml.

@kaby76
Copy link
Contributor

kaby76 commented Sep 28, 2024

Please synch with "master" to see whether the build is fixed.

@teverett
Copy link
Member

@kaby76 ready to merge?

@kaby76
Copy link
Contributor

kaby76 commented Sep 29, 2024

@teverett Yes, please merge.

@teverett
Copy link
Member

@RobEin thanks!

@teverett teverett merged commit 6d13b10 into antlr:master Sep 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants