Merge pull request #218 from spaze/spaze/phpstan-strict-rules

Add phpstan/phpstan-strict-rules
antonioribeiro · Oct 14, 2024 · 264dc6f · 264dc6f
2 parents 75fa22a + bc49457
commit 264dc6f
Show file tree

Hide file tree

Showing 6 changed files with 104 additions and 100 deletions.
diff --git a/composer.json b/composer.json
@@ -21,7 +21,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^7.5.15|^8.5|^9.0",
-        "phpstan/phpstan": "^1.9"
+        "phpstan/phpstan": "^1.9",
+        "phpstan/phpstan-strict-rules": "^1.6"
     },
     "autoload": {
         "psr-4": {

diff --git a/phpstan.neon b/phpstan.neon
@@ -7,3 +7,4 @@ parameters:
 
 includes:
   - phar://phpstan.phar/conf/bleedingEdge.neon
+  - vendor/phpstan/phpstan-strict-rules/rules.neon
diff --git a/src/Google2FA.php b/src/Google2FA.php
@@ -289,7 +289,7 @@ public function setEnforceGoogleAuthenticatorCompatibility(
     public function setAlgorithm(string $algorithm): static
     {
         // Default to SHA1 HMAC algorithm
-        if (!in_array($algorithm, $this->getValidAlgorithms())) {
+        if (!in_array($algorithm, $this->getValidAlgorithms(), true)) {
             throw new InvalidAlgorithmException();
         }
 

diff --git a/src/Support/Base32.php b/src/Support/Base32.php
@@ -38,7 +38,7 @@ public function generateBase32RandomKey(
         #[\SensitiveParameter]
         string $prefix = ''
     ): string {
-        $secret = $prefix ? $this->toBase32($prefix) : '';
+        $secret = $prefix !== '' ? $this->toBase32($prefix) : '';
 
         $secret = $this->strPadBase32($secret, $length);