fixes WordPress#1520 by adding validation that the Alt value is not e…

…mpty
antpb · Oct 10, 2018 · f76dfec · f76dfec
1 parent 2fe8cc0
commit f76dfec
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -110,6 +110,14 @@ class ImageEdit extends Component {
 		}
 	}
 
+	checkAltValue( altText, filename ) {
+		if ( ! altText ) {
+			this.props.setAttributes( { alt: 'This image has an empty alt attribute, the file name is ' + filename } );
+			return;
+		}
+		this.props.setAttributes( { alt: altText } );
+	}
+
 	onSelectImage( media ) {
 		if ( ! media || ! media.url ) {
 			this.props.setAttributes( {
@@ -120,8 +128,9 @@ class ImageEdit extends Component {
 			} );
 			return;
 		}
+		this.checkAltValue( media.alt, media.filename );
 		this.props.setAttributes( {
-			...pick( media, [ 'alt', 'id', 'caption', 'url' ] ),
+			...pick( media, [ 'id', 'caption', 'url' ] ),
 			width: undefined,
 			height: undefined,
 		} );