Skip to content

Commit

Permalink
Add "Deprecated" annotation to Pending
Browse files Browse the repository at this point in the history
Add a "Deprecated" annotation to Pending, so that the IDE will show hints that
this phase is deprecated.

Signed-off-by: shi0rik0 <[email protected]>
  • Loading branch information
shi0rik0 committed Jul 12, 2023
1 parent 839df8c commit 30f6f81
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/apis/crd/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
type TraceflowPhase string

const (
// Pending is not used anymore
// Deprecated: Pending is not used anymore
Pending TraceflowPhase = "Pending"
Running TraceflowPhase = "Running"
Succeeded TraceflowPhase = "Succeeded"
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/traceflow/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ func (c *Controller) syncTraceflow(traceflowName string) error {
return err
}
switch tf.Status.Phase {
//lint:ignore SA1019 Allow existing use.
case "", crdv1alpha1.Pending:
err = c.startTraceflow(tf)
case crdv1alpha1.Running:
Expand Down

0 comments on commit 30f6f81

Please sign in to comment.