Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodically verify that all required routes are present in the Node #627

Closed
antoninbas opened this issue Apr 18, 2020 · 3 comments · Fixed by #2091
Closed

Periodically verify that all required routes are present in the Node #627

antoninbas opened this issue Apr 18, 2020 · 3 comments · Fixed by #2091
Assignees
@hty690
Labels
area/component/agent Issues or PRs related to the agent component good first issue Good for newcomers kind/design Categorizes issue or PR as related to design. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal A concrete proposal for adding a feature

Comments

@antoninbas
Copy link
Contributor

Describe what you are trying to solve
At the moment if a route is deleted manually or by some other process like networkd, the route is never installed again until the agent on that Node restarts. See #626

Describe the solution you have in mind
Other CNIs (e.g. flannel - https://github.com/coreos/flannel/blob/v0.12.0/backend/route_network.go#L159) do periodic checks to ensure all the required routes are present. We should consider doing the same in Antrea.

Describe how your solution impacts user flows
No negative impact on users, it makes Antrea more robust,

Describe the main design/architecture of your solution
A goroutine is added (e.g. in the RouteClient) to sync the in-memory state and realized state.

Test plan
A new e2e test will be added which will remove a route while the agent is running and verify that it is added back in a timely manner.

Additional context
We may also want to periodically verify the IP configuration for gw0 (see #626)?
@antoninbas antoninbas added proposal A concrete proposal for adding a feature kind/design Categorizes issue or PR as related to design. area/component/agent Issues or PRs related to the agent component priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 18, 2020
@antoninbas antoninbas mentioned this issue Apr 18, 2020
Closed
@antoninbas antoninbas self-assigned this Apr 29, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@antoninbas antoninbas added good first issue Good for newcomers and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 4, 2021
@antoninbas antoninbas removed their assignment Mar 4, 2021
@hty690
Copy link
Contributor

hty690 commented Apr 8, 2021

I can take on this job.

@tnqn
Copy link
Member

tnqn commented Apr 8, 2021

thanks @hty690

hty690 added a commit to hty690/antrea that referenced this issue Apr 14, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
cdaf65b 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. The client also checks if the IP configuration of the gateway
is correct. An e2e test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
@hty690 hty690 mentioned this issue Apr 14, 2021
Merged
hty690 added a commit to hty690/antrea that referenced this issue Apr 14, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
d1f2b60 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. The client also checks if the IP configuration of the gateway
is correct. An e2e test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 14, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
5f687f9 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. The client also checks if the IP configuration of the gateway
is correct. An e2e test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 15, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
06a345b 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An e2e test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 15, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
808637f 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An e2e test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 21, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
784eb16 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 22, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
91165d5 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 22, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
e7aeaba 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 26, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
21fef24 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
hty690 added a commit to hty690/antrea that referenced this issue Apr 26, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
1810e68 
…periodically

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes antrea-io#627
tnqn pushed a commit that referenced this issue Apr 28, 2021
@hty690
Verify the status of required routes and IP configuration of gateway …
7355d27 
…periodically (#2091)

Add checks to the routeClient. The required routes will be added back if they were
deleted unexpectedly. Add IP configuration check of the gateway to the agent.
An integration test is added to verify that the route will be added back correctly.

Fixes #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hty690 hty690

Labels
area/component/agent Issues or PRs related to the agent component good first issue Good for newcomers kind/design Categorizes issue or PR as related to design. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal A concrete proposal for adding a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify the status of required routes gateway periodically hty690/antrea
3 participants
@antoninbas @tnqn @hty690