Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate some features from Alpha to Beta #1531

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Graduate some features from Alpha to Beta #1531

merged 3 commits into from
Nov 13, 2020

Conversation

antoninbas
Copy link
Contributor

  • AntreaProxy
  • Traceflow
  • Prometheus metrics (not controlled by a feature gate but by a boolean
    config parameter, which now defaults to 'true')

This change required a few modifications to some of our test scripts.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@antoninbas antoninbas added this to the Antrea v0.11.0 release milestone Nov 11, 2020
@codecov-io
Copy link

codecov-io commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #1531 (52141ac) into master (9d3d10b) will increase coverage by 0.96%.
The diff coverage is 58.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   63.31%   64.28%   +0.96%     
==========================================
  Files         170      181      +11     
  Lines       14250    15180     +930     
==========================================
+ Hits         9023     9758     +735     
- Misses       4292     4395     +103     
- Partials      935     1027      +92
Flag Coverage Δ
e2e-tests 48.43% <39.11%> (?)
kind-e2e-tests 52.05% <50.94%> (-3.33%) ⬇️
unit-tests 40.72% <12.37%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options.go 21.69% <0.00%> (+0.97%) ⬆️
pkg/agent/stats/collector.go 97.72% <ø> (ø)
pkg/features/antrea_features.go 16.66% <ø> (ø)
pkg/ovs/openflow/ofctrl_builder.go 60.58% <0.00%> (-1.59%) ⬇️
pkg/ovs/openflow/ofctrl_group.go 48.57% <0.00%> (-4.56%) ⬇️
pkg/ovs/openflow/ofctrl_action.go 71.00% <17.14%> (+9.65%) ⬆️
pkg/agent/proxy/types/types.go 60.00% <33.33%> (-24.62%) ⬇️
pkg/controller/networkpolicy/validate.go 46.08% <33.33%> (+1.25%) ⬆️
pkg/agent/controller/networkpolicy/reconciler.go 71.80% <50.00%> (+0.48%) ⬆️
... and 64 more

tnqn
tnqn previously approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

jianjuns
jianjuns previously approved these changes Nov 11, 2020
View reviewed changes
docs/feature-gates.md Outdated
Windows. In order to support cluster Services as the destination for tracing
requests, `AntreaProxy` should be enabled (it is not enabled by default for
Linux Nodes in "encap" mode)..
Until Antrea v0.11 and its graduation to Beta, this feature could only be used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to explicitly say after v0.11 the requirement is gone?

@ksamoray
Copy link
Contributor

LGTM, got a minor suggestion: test-e2e-kind.sh won't run the tests with -prometheus, yet I think that the manifest will enable prometheus by default. We could maybe remove the skip from the tests which do not require Prometheus server.

lzhecheng
lzhecheng previously approved these changes Nov 12, 2020
View reviewed changes
@antoninbas antoninbas dismissed stale reviews from lzhecheng, jianjuns, and tnqn via 9e4396a November 12, 2020 19:26
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-ipv6-all
/test-ipv6-only-all

@antoninbas
Graduate some features from Alpha to Beta
2468ff9 
 * AntreaProxy
 * Traceflow
 * Prometheus metrics (not controlled by a feature gate but by a boolean
   config parameter, which now defaults to 'true')

This change required a few modifications to some of our test scripts.
@antoninbas
Skip inter-Node Traceflow test on Kind in encap mode
52141ac
@antoninbas
Copy link
Contributor Author

/test-all
/test-ipv6-all
/test-ipv6-only-all

@antoninbas
Copy link
Contributor Author

LGTM, got a minor suggestion: test-e2e-kind.sh won't run the tests with -prometheus, yet I think that the manifest will enable prometheus by default. We could maybe remove the skip from the tests which do not require Prometheus server.

@ksamoray thanks for pointing this out, I think that's something we could address in a follow-up PR

@antoninbas
Copy link
Contributor Author

/test-all-features-conformance

@antoninbas
Copy link
Contributor Author

/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-ipv6-only-networkpolicy

@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e

@antoninbas
Copy link
Contributor Author

/test-windows-conformance

@lzhecheng
Copy link
Contributor

/test-ipv6-only-conformance
/test-ipv6-only-networkpolicy

@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-only-e2e

@lzhecheng
Copy link
Contributor

/test-ipv6-only-e2e

@lzhecheng
Copy link
Contributor

/test-ipv6-only-conformance

@antoninbas
Copy link
Contributor Author

/test-ipv6-all

@antoninbas
Copy link
Contributor Author

/test-ipv6-only-networkpolicy
/test-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-all

tnqn
tnqn approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 24c0cb0 into antrea-io:master Nov 13, 2020
@antoninbas antoninbas deleted the graduate-features-to-beta branch November 13, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@jianjuns jianjuns jianjuns left review comments

@lzhecheng lzhecheng lzhecheng left review comments

@ksamoray ksamoray Awaiting requested review from ksamoray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.11.0 release
Development

Successfully merging this pull request may close these issues.
8 participants
@antoninbas @antrea-bot @codecov-io @ksamoray @lzhecheng @tnqn @jianjuns @vmwclabot