Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up portmap version to v0.8.7 #1534

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Nov 11, 2020

To fix a performance issue that portmap performs expensive iptables
operations even no portMappings are configured.

Upstream fix: containernetworking/plugins@877602d

Fixes #1499

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #1534 (671a931) into master (6c1a913) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
- Coverage   67.79%   67.65%   -0.14%     
==========================================
  Files         169      169              
  Lines       13503    13503              
==========================================
- Hits         9154     9136      -18     
- Misses       3407     3420      +13     
- Partials      942      947       +5     
Flag Coverage Δ
integration-tests 45.64% <ø> (-0.07%) ⬇️
kind-e2e-tests 55.18% <ø> (-0.39%) ⬇️
unit-tests 41.17% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/certificate.go 71.05% <0.00%> (-6.58%) ⬇️
pkg/controller/traceflow/controller.go 67.74% <0.00%> (-2.59%) ⬇️
pkg/ovs/openflow/ofctrl_bridge.go 70.35% <0.00%> (-1.59%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 82.97% <0.00%> (-0.73%) ⬇️

@tnqn
Copy link
Member Author

tnqn commented Nov 11, 2020

/test-all

@tnqn
Copy link
Member Author

tnqn commented Nov 11, 2020

@antoninbas I haven't updated the base image, want the PR get reviewed first. If it gets approval, could you help update the image and merge it to catch 0.10.2?

To fix a performance issue that portmap performs expensive iptables
operations even no portMappings are configured.
@tnqn
Copy link
Member Author

tnqn commented Nov 11, 2020

/test-all

@tnqn tnqn added this to the Antrea v0.11.0 release milestone Nov 11, 2020
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 24cffda into antrea-io:master Nov 11, 2020
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Nov 11, 2020
To fix a performance issue that portmap performs expensive iptables
operations even no portMappings are configured.
antoninbas pushed a commit that referenced this pull request Nov 11, 2020
To fix a performance issue that portmap performs expensive iptables
operations even no portMappings are configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antrea-agent kept crashing on iptables error after restarting a Node with many Pods running on it
6 participants