[Flow-Aggregator] Implementation of flow aggregator build system and structure #1558

dreamtalen · 2020-11-13T23:04:31Z

This is the first PR of flow aggregator implementation, which only contains the build system and structure of it, including the yaml files, github workflow changes and command line tools. For the main logic of flow aggregator, please take a look at this PR (#1596).

antrea-bot · 2020-11-13T23:04:46Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
/skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

srikartati

Thanks for the PR @dreamtalen
We should probably change the name of featureGate in Antrea agent as FlowVisbilty instead of FlowExporter to incorporate the flow-aggregator implementation in the same feature gate. What do you think?

srikartati · 2020-11-15T17:13:42Z

build/images/flowaggregator/Dockerfile

+
+USER root
+
+COPY bin/flow-aggregator /usr/local/bin/


Do we expect the consumer of this dockerfile to compile the flow-aggregator code as a pre-requisite?
Maybe it is better to include the compilation steps for flow-aggregator binary in the dockerfile itself as it is being done for Antrea image.

Thanks, added.

srikartati · 2020-11-15T17:15:32Z

build/yamls/flow-aggregator/flow-aggregator.yml

+        command:
+          - flow-aggregator
+        name: flow-aggregator
+        image: dreamtalen/flow-aggregator


Are you planning to use Antrea org in dockerhub registry to maintain the image?

Yes, changed the image name to antrea/flow-aggregator

srikartati · 2020-11-15T17:19:59Z

cmd/flow-aggregator/flow-aggregator.go

+package main
+
+import (
+	aggregator "github.com/vmware-tanzu/antrea/pkg/flowaggregator"


Please use the convention followed in Antrea.
Can you request Antonin to enable the github workflows (golang linters, spell check, unit test etc.) for feature/flow-aggregator branch?

Thanks, done.

srikartati · 2020-11-15T17:21:34Z

cmd/flow-aggregator/main.go

+
+	"github.com/spf13/cobra"
+	"github.com/vmware-tanzu/antrea/pkg/log"
+	"github.com/vmware-tanzu/antrea/pkg/version"


here too and same everywhere.

srikartati · 2020-11-15T17:25:44Z

cmd/flow-aggregator/options.go

+		}
+
+		// Convert the string input in net.Addr format
+		hostPortAddr := strSlice[0] + ":" + strSlice[1]


Better to take care of flow collector having an IPv6 address like it is done here.
#1541
This PR will be checked in soon.

Thanks, I'm thinking about taking care it in next PR.

srikartati · 2020-11-15T17:29:44Z

pkg/flowaggregator/flowaggregator.go

+		case <-stopCh:
+			break
+		case <-exportTicker.C:
+			curMsgs := cp.GetMessages()


could you move to go-ipfix v0.3.0 and use the message channel in collector instead?

Sure, this PR is based on a commit of go-ipfix before intermediate process merged. In the second PR which I'm working on now, I have moved to go-ipfix v0.3.0 and some other comments will be addressed in that PR too.

Ok. Will wait for other PR, but please try not to make PRs bulky. It may be hard for code-reviewers to review.

srikartati · 2020-11-15T17:33:11Z

pkg/flowaggregator/flowaggregator.go

+func (fae *flowAggregator) Run(stopCh <-chan struct{}) {
+	// Go-ipfix TCP collector doesn't work during my last test, fixed as udp temporarily.
+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)


how is the flow-aggregator collector address fed to the flow exporter at antrea-agent?

srikartati · 2020-11-15T17:34:56Z

pkg/flowaggregator/flowaggregator.go

+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)
+
+	ep, err := exporter.InitExportingProcess(fae.flowCollectorAddr, 1, 0)


what if exporting process loose connection to flow collector (provided in configMap) or flow collector is restarted?

+1 - can be in a future PR but we should handle these cases, just like the Agent should be robust to connection loss to the collector or aggregator

I believe this should be done in the go-ipfix library though, just like the gRPC library handles it behind the scene (https://godoc.org/google.golang.org/grpc).

srikartati · 2020-11-15T17:36:04Z

build/yamls/flow-aggregator/flow-aggregator.yml

+    # Provide the flow collector address as string with format <IP>:<port>[:<proto>], where proto is tcp or udp.
+    # If no L4 transport proto is given, we consider tcp as default.
+    # Defaults to "".
+    flowCollectorAddr: "10.96.28.149:4739:udp"


You should use default here and not your testing collector address.

srikartati · 2020-11-15T17:37:30Z

pkg/flowaggregator/flowaggregator.go

+					setSent.AddRecord(record.GetInfoElements(), record.GetTemplateID())
+				}
+				bytesSent, err := ep.AddSetAndSendMsg(setType, setSent)
+				klog.Infof("Msg index: %d, sent bytes: %d, error: %v\n", i, bytesSent, err)


Increase the log level 4 or an appropriate level for debug messages and use error log if err is not nil.

codecov-io · 2020-11-19T22:57:19Z

Codecov Report

❗ No coverage uploaded for pull request base (feature/flow-aggregator@08d1062). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             feature/flow-aggregator    #1558   +/-   ##
==========================================================
  Coverage                           ?   61.92%           
==========================================================
  Files                              ?      181           
  Lines                              ?    15310           
  Branches                           ?        0           
==========================================================
  Hits                               ?     9480           
  Misses                             ?     4813           
  Partials                           ?     1017

Flag	Coverage Δ
kind-e2e-tests	`52.20% <0.00%> (?)`
unit-tests	`40.39% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

srikartati

I see the version of go-ipfix is v0.2.1. You should at least move to v0.2.4 which is on master. May be rebasing the feature/flow-aggregator with master helps.

srikartati · 2020-11-20T08:01:06Z

build/yamls/flow-aggregator/flow-aggregator.yml

+  selector:
+    app: flow-aggregator
+  type: NodePort
+  ports:


I think we should also expose TCP port. Using name field can be useful.

srikartati · 2020-11-20T15:26:11Z

.github/workflows/build.yml

+        DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+      run: |
+        echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
+        docker push antrea/flow-aggregator:latest


add a new line

seems like this wasn't addressed? same for build_tag.yml

srikartati · 2020-11-20T15:27:32Z

build/images/flowaggregator/Dockerfile

+
+USER root
+
+COPY --from=flowaggregator-build /antrea/bin/flow-aggregator /usr/local/bin/


add a new line

antoninbas · 2020-11-20T19:17:10Z

build/images/flowaggregator/Dockerfile

+
+RUN make flow-aggregator
+
+FROM antrea/base-ubuntu:2.14.0


add metadata (see other Dockerfiles in the repo for examples)

antoninbas · 2020-11-20T19:19:43Z

build/images/flowaggregator/Dockerfile

@@ -0,0 +1,13 @@
+FROM golang:1.15 as flowaggregator-build


maybe the directory should be called flow-aggregator to match the image name

Makefile

.github/workflows/build.yml

antoninbas · 2020-11-20T19:26:16Z

build/yamls/flow-aggregator/flow-aggregator.yml

@@ -0,0 +1,80 @@
+apiVersion: v1


This manifest needs to be integrated with hack/generate-manifest.sh.

In particular generate-manifest.sh should support generating a release version of the manifest for which the docker image tag is the correct release tag. This manifest should be automatically uploaded to release assets when a Github release is created (so you need to edit upload_release_assets.yml).

Make sure that you double check everything and that you test hack/generate-manifest.sh locally, otherwise it breaks the release flow.

antoninbas · 2020-11-20T19:26:27Z

build/yamls/flow-aggregator/flow-aggregator.yml

+      - name: flow-aggregator-config
+        configMap:
+          name: flow-aggregator-configmap
+


there is an extra empty line here

antoninbas · 2020-11-20T19:29:35Z

The manifest needs to be integrated with hack/generate-manifest & kustomize. We need to have a dev version of the manifest and a release version of the manifest.

Changes to upload_release_assets.yml and build_tag.yml can be postponed to a future PR. It's important to get them right since these workflows are not exercised until we make an actual release.

srikartati · 2020-11-24T04:31:25Z

cmd/flow-aggregator/config.go

+	// records to the flow collector.
+	// Flow export frequency should be greater than or equal to 1s(one second).
+	// Defaults to "60s". Follow the time units of duration.
+	FlowExportFrequency string `yaml:"flowExportFrequency,omitempty"`


FlowExportInterval is a better name here. Frequency is usually the inverse of time.

Thanks, addressed.

dreamtalen · 2020-12-01T06:16:59Z

The manifest needs to be integrated with hack/generate-manifest & kustomize. We need to have a dev version of the manifest and a release version of the manifest.

Changes to upload_release_assets.yml and build_tag.yml can be postponed to a future PR. It's important to get them right since these workflows are not exercised until we make an actual release.

Thanks, just addressed these comments.

lzhecheng · 2020-12-01T07:05:00Z

build/yamls/flow-aggregator/base/kustomization.yml

+  app: flow-aggregator
+namespace: flow-aggregator
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization


Better to have an extra empty line here.

Thanks, done.

lzhecheng · 2020-12-01T07:05:40Z

build/yamls/flow-aggregator/base/conf/flow-aggregator.conf

+# Flow export interval should be greater than or equal to 1s (one second).
+# Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
+# Defaults to "60s".
+flowExportInterval: 60s


srikartati · 2020-12-01T08:49:12Z

.github/workflows/golicense.yml

@@ -4,10 +4,12 @@ on:
    branches:
    - master
    - release-*
+    - feature/flow-aggregator


do we need go license workflow for feature branch?

Thanks, removed feature/flow-aggregator in go license and kind update workflow since they are not essential.

srikartati · 2020-12-01T08:53:16Z

build/images/flow-aggregator/Dockerfile

+
+USER root
+
+COPY --from=flow-aggregator-build /antrea/bin/flow-aggregator /usr/local/bin/


srikartati

Please look at the workflow failures corresponding to linters, compiling the binary and unit tests.

build/yamls/flow-aggregator.yml

antoninbas

some comments, but I'm satisfied with the Github workflow changes and build system changes

.github/workflows/build.yml

antoninbas · 2020-12-03T23:14:36Z

build/images/flow-aggregator/Dockerfile

+LABEL maintainer="Antrea <[email protected]>"
+LABEL description="The docker image for flow aggregator"


these label statements should come after the last FROM statement if I recall correctly?

antoninbas · 2020-12-03T23:20:54Z

build/yamls/flow-aggregator/patches/release/.gitignore

@@ -0,0 +1 @@
+# placeholder


I believe the convention is an empty file called .gitkeep

ok, I was following the style in build/yamls/octant/ or windows/, could you please check again?

I added the .gitignore file before I became aware of the .gitkeep "convention", but that's a pretty minor point anyway. Feel free to update all of them to .gitkeep as part of this PR or keep is as it is.

antoninbas · 2020-12-03T23:23:46Z

cmd/flow-aggregator/config.go

+	// Provide flow export interval as a duration string. This determines how often the flow aggregator exports flow
+	// records to the flow collector.
+	// Flow export interval should be greater than or equal to 1s (one second).
+	// Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
+	// Defaults to "60s".
+	FlowExportInterval string `yaml:"flowExportInterval,omitempty"`


Probably a bit out of scope of this PR, but IIRC Rob Cowart recommended that we spread the export over the time interval (both in the agent and in the aggregator), to avoid all records arriving at the same time

Yes using different export intervals for active and inactive flows need a proposal. We need to add the notion of inactive flows in the exported IPFIX fields.

I think this becomes especially important at the aggregator, which will generate more traffic than each individual agent presumably

antoninbas · 2020-12-03T23:26:05Z

hack/generate-manifest-flow-aggregator.sh

+}
+
+_usage="Usage: $0 [--mode (dev|release)] [--keep] [--help|-h]
+Generate a YAML manifest to run Antrea on Windows Nodes, using Kustomize, and print it to stdout.


Update the comment

antoninbas · 2020-12-03T23:29:50Z

pkg/flowaggregator/flowaggregator.go

+	defer exportTicker.Stop()
+	sentMsgNum := 0
+	go cp.Start()
+	for {


so all the logic necessary to store connection state and reconcile flows from source and destination Nodes will go here in a future PR?

antoninbas · 2020-12-03T23:30:47Z

pkg/flowaggregator/flowaggregator.go

+	defer exportTicker.Stop()
+	sentMsgNum := 0
+	go cp.Start()
+	for {


you may want to review whether all the log messages in this loop are necessary or have the correct verbosity?

antoninbas · 2020-12-03T23:31:26Z

pkg/flowaggregator/flowaggregator.go

+func (fae *flowAggregator) Run(stopCh <-chan struct{}) {
+	// Go-ipfix TCP collector doesn't work during my last test, fixed as udp temporarily.
+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)


why is the error ignored?

antoninbas · 2020-12-03T23:33:16Z

pkg/flowaggregator/flowaggregator.go

+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)
+
+	ep, err := exporter.InitExportingProcess(fae.flowCollectorAddr, 1, 0)


+1 - can be in a future PR but we should handle these cases, just like the Agent should be robust to connection loss to the collector or aggregator

I believe this should be done in the go-ipfix library though, just like the gRPC library handles it behind the scene (https://godoc.org/google.golang.org/grpc).

antoninbas · 2020-12-03T23:34:03Z

pkg/flowaggregator/flowaggregator.go

+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)
+
+	ep, err := exporter.InitExportingProcess(fae.flowCollectorAddr, 1, 0)


is there some symmetry in the go-ipfix implementation for the agent -> aggregator connection and the aggregator -> collector connection? @srikartati

@antoninbas Yes, both use the same exporting process from go-ipfix library, if you meant from the perspective of library functions used. Exporter code in Antrea for agent-aggregator and aggregator-collector will look similar, but the fields will be different. In the future, we could try to consolidate.

dreamtalen · 2020-12-04T01:09:58Z

some comments, but I'm satisfied with the Github workflow changes and build system changes

Antonin, thanks for your comments. The logic in pkg/flowaggregator/flowaggregator.go has changed a lot since the go-ipfix version moved from v0.2.1 -> v0.3.1, so please check the second PR (#1596) about the main logic of flow aggregator. Other comments will be addressed soon.

srikartati

@antoninbas Yes there is dependency with go-ipfix versions. That is why there are some errors in workflows too.

@dreamtalen Actually, could you remove this file from the PR entirely and check-in as part of PR #1596? Or keep some minimal code.

srikartati · 2020-12-04T07:43:03Z

pkg/flowaggregator/flowaggregator.go

+	collectAddr, _ := net.ResolveUDPAddr("udp", "0.0.0.0:4739")
+	cp, _ := collector.InitCollectingProcess(collectAddr, 1024, 0)
+
+	ep, err := exporter.InitExportingProcess(fae.flowCollectorAddr, 1, 0)


@antoninbas Yes, both use the same exporting process from go-ipfix library, if you meant from the perspective of library functions used. Exporter code in Antrea for agent-aggregator and aggregator-collector will look similar, but the fields will be different. In the future, we could try to consolidate.

build/yamls/flow-aggregator.yml

dreamtalen · 2020-12-08T19:49:26Z

@antoninbas Yes there is dependency with go-ipfix versions. That is why there are some errors in workflows too.

@dreamtalen Actually, could you remove this file from the PR entirely and check-in as part of PR #1596? Or keep some minimal code.

Thanks, I removed most logic in pkg/flowaggregator/flowaggregator.go and will update the description of this commit.

srikartati

LGTM except for one comment on building the flow-aggregator image through make.

srikartati · 2020-12-08T20:43:29Z

Makefile

@@ -306,6 +312,16 @@ octant-antrea-ubuntu:
 	docker build --pull -t antrea/octant-antrea-ubuntu:$(DOCKER_IMG_VERSION) -f build/images/Dockerfile.octant.ubuntu .
 	docker tag antrea/octant-antrea-ubuntu:$(DOCKER_IMG_VERSION) antrea/octant-antrea-ubuntu

+.PHONY: flow-aggregator-ubuntu


should we add this target along with build-ubuntu to get executed when we do make? Or expect folks to build image by using the target directly? @antoninbas what do you think?

I think we can keep it as it is for now and make the change in the future if we feel like we need to

srikartati · 2020-12-09T09:31:26Z

/test-all

antoninbas

some small comments, otherwise LGTM

main comment on my side is that I don't think the flow aggregator needs to be a NodePort Service?

antoninbas · 2020-12-09T19:54:31Z

.github/workflows/build.yml

+        DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+      run: |
+        echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
+        docker push antrea/flow-aggregator:latest


seems like this wasn't addressed? same for build_tag.yml

antoninbas · 2020-12-09T19:58:34Z

Makefile

@@ -306,6 +312,16 @@ octant-antrea-ubuntu:
 	docker build --pull -t antrea/octant-antrea-ubuntu:$(DOCKER_IMG_VERSION) -f build/images/Dockerfile.octant.ubuntu .
 	docker tag antrea/octant-antrea-ubuntu:$(DOCKER_IMG_VERSION) antrea/octant-antrea-ubuntu

+.PHONY: flow-aggregator-ubuntu


I think we can keep it as it is for now and make the change in the future if we feel like we need to

antoninbas · 2020-12-09T19:59:15Z

build/images/flow-aggregator/Dockerfile

+FROM antrea/base-ubuntu:2.14.0
+
+LABEL maintainer="Antrea <[email protected]>"
+LABEL description="The docker image for flow aggregator"


for the flow aggregator

antoninbas · 2020-12-09T20:00:24Z

build/yamls/flow-aggregator/base/flow-aggregator.yml

+spec:
+  selector:
+    app: flow-aggregator
+  type: NodePort


maybe I am missing something, but why is this a NodePort Service? a ClusterIP is enough for the agent to connect to the aggregator

Yes, I have removed the NodePort type declaration in the second PR, sorry for not merging it into this PR.

antoninbas · 2020-12-09T20:04:13Z

build/yamls/flow-aggregator/base/conf/flow-aggregator.conf

@@ -0,0 +1,11 @@
+# Provide the flow collector address as string with format <IP>:<port>[:<proto>], where proto is tcp or udp.
+# If no L4 transport proto is given, we consider tcp as default.
+# Defaults to "".


nit: don't think this line is needed

Sorry, do you mean these description lines are not needed for parameters in flow-aggregator.conf?

yes, I don't believe we typically include them in the .conf file, since the default value is obvious from the commented-out line

Got it, thanks.

antoninbas · 2020-12-09T20:04:19Z

build/yamls/flow-aggregator/base/conf/flow-aggregator.conf

+# records to the flow collector.
+# Flow export interval should be greater than or equal to 1s (one second).
+# Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
+# Defaults to "60s".


antoninbas · 2020-12-09T20:05:34Z

build/yamls/flow-aggregator/patches/release/.gitignore

@@ -0,0 +1 @@
+# placeholder


I added the .gitignore file before I became aware of the .gitkeep "convention", but that's a pretty minor point anyway. Feel free to update all of them to .gitkeep as part of this PR or keep is as it is.

antoninbas · 2020-12-09T20:06:41Z

cmd/flow-aggregator/config.go

+	// Provide flow export interval as a duration string. This determines how often the flow aggregator exports flow
+	// records to the flow collector.
+	// Flow export interval should be greater than or equal to 1s (one second).
+	// Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
+	// Defaults to "60s".
+	FlowExportInterval string `yaml:"flowExportInterval,omitempty"`


I think this becomes especially important at the aggregator, which will generate more traffic than each individual agent presumably

antoninbas · 2020-12-09T20:07:42Z

pkg/flowaggregator/flowaggregator.go

+	}
+}
+
+func (fae *flowAggregator) Run(stopCh <-chan struct{}) {


nit: why fae instead of fa?

Changed to fa, will also update the variable name in subsequent PRs.

antoninbas · 2020-12-09T20:09:11Z

cmd/flow-aggregator/options.go

+	}
+	if o.config.FlowCollectorAddr == "" {
+		return fmt.Errorf("IPFIX flow collector address should be provided")
+	} else {


if the address parsing logic can be unified with the agent, please consider doing it in a subsequent PR

srikartati

LGTM.
Seems like all comments are addressed. Requesting re-review of @antoninbas

This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

antoninbas

LGTM

…io#1558) This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

…io#1558) This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

…io#1558)

…io#1558) This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

vmwclabot added the cla-not-required label Nov 13, 2020

srikartati reviewed Nov 15, 2020

View reviewed changes

srikartati reviewed Nov 20, 2020

View reviewed changes

antoninbas reviewed Nov 20, 2020

View reviewed changes

antoninbas requested a review from lzhecheng November 20, 2020 19:29

srikartati reviewed Nov 24, 2020

View reviewed changes

dreamtalen changed the title ~~Flow aggregator implementation with only collector and exporter~~ [Flow Aggregator] Flow aggregator implementation with only collector and exporter Nov 30, 2020

dreamtalen changed the title ~~[Flow Aggregator] Flow aggregator implementation with only collector and exporter~~ [Flow-Aggregator] Flow aggregator implementation with only collector and exporter Nov 30, 2020

dreamtalen force-pushed the local-flow-aggregator branch from 9c7cd9e to 07abb25 Compare November 30, 2020 18:41

lzhecheng reviewed Dec 1, 2020

View reviewed changes

srikartati reviewed Dec 1, 2020

View reviewed changes

dreamtalen force-pushed the local-flow-aggregator branch 2 times, most recently from 43dc23a to a188844 Compare December 2, 2020 00:39

srikartati mentioned this pull request Dec 3, 2020

Upgrade go-ipfix to v0.3.1 #1582

Merged

srikartati reviewed Dec 3, 2020

View reviewed changes

build/yamls/flow-aggregator.yml Show resolved Hide resolved

dreamtalen force-pushed the local-flow-aggregator branch from a188844 to 99e0241 Compare December 3, 2020 18:40

antoninbas reviewed Dec 3, 2020

View reviewed changes

dreamtalen force-pushed the local-flow-aggregator branch from 99e0241 to 4df9211 Compare December 4, 2020 01:32

srikartati reviewed Dec 4, 2020

View reviewed changes

srikartati added this to the Antrea v0.12.0 release milestone Dec 8, 2020

dreamtalen force-pushed the local-flow-aggregator branch from 4df9211 to bcd78dc Compare December 8, 2020 19:48

srikartati reviewed Dec 8, 2020

View reviewed changes

dreamtalen changed the title ~~[Flow-Aggregator] Flow aggregator implementation with only collector and exporter~~ [Flow-Aggregator] Implementation of flow aggregator build system and structure Dec 8, 2020

antoninbas reviewed Dec 9, 2020

View reviewed changes

dreamtalen force-pushed the local-flow-aggregator branch 2 times, most recently from 1cb3a07 to 80e1ad7 Compare December 10, 2020 17:37

srikartati approved these changes Dec 10, 2020

View reviewed changes

srikartati requested a review from antoninbas December 10, 2020 17:46

dreamtalen force-pushed the local-flow-aggregator branch 2 times, most recently from 7c5d6f0 to 8dce57a Compare December 10, 2020 18:54

Implementation of flow aggregator build system and structure

9d819d6

This is the first PR of flow aggregator implementation, which only contains the build system and main structure of it, including the yaml files, github workflow changes and command linue tools.

dreamtalen force-pushed the local-flow-aggregator branch from 8dce57a to 9d819d6 Compare December 10, 2020 21:43

antoninbas approved these changes Dec 10, 2020

View reviewed changes

srikartati merged commit 269eb5e into antrea-io:feature/flow-aggregator Dec 10, 2020

zyiou pushed a commit to zyiou/antrea that referenced this pull request Dec 17, 2020

Implementation of flow aggregator build system and structure (antrea-…

590a49a

…io#1558)


		USER root

		COPY --from=flowaggregator-build /antrea/bin/flow-aggregator /usr/local/bin/


		USER root

		COPY --from=flow-aggregator-build /antrea/bin/flow-aggregator /usr/local/bin/

		LABEL maintainer="Antrea <[email protected]>"
		LABEL description="The docker image for flow aggregator"

[Flow-Aggregator] Implementation of flow aggregator build system and structure #1558

[Flow-Aggregator] Implementation of flow aggregator build system and structure #1558

Conversation

dreamtalen commented Nov 13, 2020 • edited Loading

antrea-bot commented Nov 13, 2020

srikartati left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srikartati Nov 15, 2020 • edited Loading

Choose a reason for hiding this comment

codecov-io commented Nov 19, 2020 • edited Loading

Codecov Report

srikartati left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antoninbas commented Nov 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreamtalen commented Dec 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreamtalen Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srikartati left a comment

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srikartati Dec 4, 2020 • edited Loading

Choose a reason for hiding this comment

dreamtalen commented Dec 4, 2020

srikartati left a comment • edited Loading

Choose a reason for hiding this comment

srikartati Dec 4, 2020 • edited Loading

Choose a reason for hiding this comment

dreamtalen commented Dec 8, 2020

srikartati left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srikartati commented Dec 9, 2020

antoninbas left a comment

Choose a reason for hiding this comment

dreamtalen commented Nov 13, 2020 •

edited

Loading

srikartati Nov 15, 2020 •

edited

Loading

codecov-io commented Nov 19, 2020 •

edited

Loading

dreamtalen Dec 1, 2020 •

edited

Loading

srikartati Dec 4, 2020 •

edited

Loading

srikartati left a comment •

edited

Loading

srikartati Dec 4, 2020 •

edited

Loading

srikartati left a comment •

edited

Loading