Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPv6] Traceflow IPv6 support #1579

Merged
merged 1 commit into from
Jan 15, 2021
Merged

[IPv6] Traceflow IPv6 support #1579

merged 1 commit into from
Jan 15, 2021

Conversation

gran-vmv
Copy link
Contributor

@gran-vmv gran-vmv commented Nov 19, 2020 •
edited
Loading

This PR replaces #1283

@gran-vmv gran-vmv added the status/WIP Work in progress label Nov 19, 2020
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-io
Copy link

codecov-io commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #1579 (afbf335) into master (9d3d10b) will decrease coverage by 21.57%.
The diff coverage is 38.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1579       +/-   ##
===========================================
- Coverage   63.31%   41.74%   -21.58%     
===========================================
  Files         170      107       -63     
  Lines       14250    13517      -733     
===========================================
- Hits         9023     5643     -3380     
- Misses       4292     7391     +3099     
+ Partials      935      483      -452
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 41.74% <38.62%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
pkg/agent/agent.go 12.20% <0.00%> (-36.51%) ⬇️
pkg/agent/agent_linux.go 0.00% <0.00%> (-100.00%) ⬇️
...g/agent/cniserver/interface_configuration_linux.go 5.79% <0.00%> (-14.44%) ⬇️
pkg/agent/cniserver/pod_configuration.go 34.52% <0.00%> (-19.24%) ⬇️
pkg/agent/config/node_config.go 0.00% <0.00%> (-100.00%) ⬇️
...gent/controller/noderoute/node_route_controller.go 32.57% <0.00%> (-13.90%) ⬇️
pkg/agent/controller/traceflow/packetin.go 10.91% <0.00%> (-53.37%) ⬇️
...agent/controller/traceflow/traceflow_controller.go 0.00% <0.00%> (-82.70%) ⬇️
pkg/agent/proxy/proxier_linux.go 0.00% <0.00%> (-25.00%) ⬇️
... and 172 more

@gran-vmv gran-vmv force-pushed the tf-ipv6 branch 2 times, most recently from 0864747 to 055ae63 Compare November 19, 2020 09:04
@gran-vmv gran-vmv removed the status/WIP Work in progress label Nov 20, 2020
@gran-vmv gran-vmv added this to the Antrea v0.12.0 release milestone Nov 23, 2020
@gran-vmv gran-vmv mentioned this pull request Dec 4, 2020
Merged
@gran-vmv gran-vmv force-pushed the tf-ipv6 branch 2 times, most recently from 4d7c746 to bba4bda Compare December 17, 2020 03:11
@gran-vmv
Copy link
Contributor Author

/test-all

@gran-vmv
Copy link
Contributor Author

/test-all-features-conformance
/test-conformance
/test-hw-offload
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy

@lzhecheng
Copy link
Contributor

/test-all-features-conformance
/test-conformance
/test-hw-offload
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy

You may use test-ipv6-all, test-ipv6-only-all to trigger all dual-stack and ipv6-only cases.

@gran-vmv
Copy link
Contributor Author

/test-all-features-conformance
/test-conformance
/test-hw-offload
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy

You may use test-ipv6-all, test-ipv6-only-all to trigger all dual-stack and ipv6-only cases.

Got it. Thanks.

tnqn
tnqn reviewed Jan 4, 2021
View reviewed changes
pkg/agent/controller/traceflow/packetin.go Outdated Show resolved Hide resolved
pkg/agent/controller/traceflow/traceflow_controller.go Outdated Show resolved Hide resolved
pkg/agent/openflow/client_test.go Outdated Show resolved Hide resolved
pkg/apis/ops/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/ovs/openflow/ofctrl_packetout.go Outdated Show resolved Hide resolved
pkg/ovs/openflow/ofctrl_packetout.go Outdated Show resolved Hide resolved
build/yamls/base/crds.yml Show resolved Hide resolved
jianjuns
jianjuns reviewed Jan 4, 2021
View reviewed changes
pkg/agent/controller/traceflow/packetin.go Outdated Show resolved Hide resolved
pkg/agent/controller/traceflow/packetin.go Outdated Show resolved Hide resolved
pkg/agent/controller/traceflow/packetin.go Outdated Show resolved Hide resolved
@gran-vmv
Copy link
Contributor Author

gran-vmv commented Jan 5, 2021

/test-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Jan 5, 2021

/test-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Jan 5, 2021

/test-e2e

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Jan 6, 2021

/test-all
/test-ipv6-all
/test-ipv6-only-all

tnqn
tnqn approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

@tnqn @gran-vmv can we merge this now?

@gran-vmv gran-vmv merged commit adea58e into antrea-io:master Jan 15, 2021
@gran-vmv gran-vmv deleted the tf-ipv6 branch January 21, 2021 09:10
@antoninbas antoninbas mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns left review comments

@tnqn tnqn tnqn approved these changes

@wenyingd wenyingd Awaiting requested review from wenyingd

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.13.0 release
Development

Successfully merging this pull request may close these issues.
8 participants
@gran-vmv @antrea-bot @codecov-io @lzhecheng @antoninbas @tnqn @jianjuns @vmwclabot