Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Node probe all local Pods #175

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Dec 3, 2019

Install Openflow entry on ingress rule table to allow the liveness probe traffic
that is sent from node to local Pods. The flow entry is installed on the ingress
rule table, matching local gateway IP as the source address, and the action is
to resubmit the packets to L2 forwarding output table.

Fixes #176

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests. This command can only be run by members of the vmware-tanzu organization
  • /skip-e2e: to skip e2e tests. This command can only be run by members of the vmware-tanzu organization

@wenyingd
Copy link
Contributor Author

wenyingd commented Dec 3, 2019

/test-e2e

pkg/agent/openflow/pipeline.go Outdated Show resolved Hide resolved
@tnqn
Copy link
Member

tnqn commented Dec 3, 2019

Maybe revise the commit message to replace table 90 and 110 with the readable table names

@wenyingd
Copy link
Contributor Author

wenyingd commented Dec 3, 2019

/test-e2e

@tnqn
Copy link
Member

tnqn commented Dec 3, 2019

Consider "Allow Node probe all local Pods" as the title

@wenyingd wenyingd changed the title Enable liveness probe of local Pods Allow Node probe all local Pods Dec 3, 2019
@wenyingd
Copy link
Contributor Author

wenyingd commented Dec 3, 2019

Sure, I will change.

tnqn
tnqn previously approved these changes Dec 3, 2019
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jianjuns please take a look if this matches your expectation.

tnqn
tnqn previously approved these changes Dec 3, 2019
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Install Openflow entry on ingress rule table to allow the liveness probe traffic
that is sent from node to local Pods. The flow entry is installed on the ingress
rule table, matching local gateway IP as the source address, and the action is
to resubmit the packets to L2 forwarding output table.

Signed-off-by: wenyingd <[email protected]>

Co-Authored-By: Quan Tian <[email protected]>
@wenyingd
Copy link
Contributor Author

wenyingd commented Dec 3, 2019

/test-e2e

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit fb96769 into antrea-io:master Dec 3, 2019
@wenyingd wenyingd deleted the local_probe branch December 6, 2019 05:50
zyiou added a commit to zyiou/antrea that referenced this pull request Jul 2, 2021
zyiou added a commit to zyiou/antrea that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container probes fail because of NetworkPolicy dropping them
6 participants