Delete IPTABLES rules for NodePortLocal when nplPortRange is updated #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside current port range are supposed to be deleted. But we face a problem if all rules have to be deleted from NPL chain. In that case we were skipping IPTABLES update - because length of allNPLPorts in GetPodsAndGenRules function was getting set to zero. Removed this length check so that even if all rules have to be deleted, the function addRulesForNPLPorts is executed.
monotosh-avi
requested review from
jianjuns,
tnqn,
antoninbas and
chauhanshubham
hemantavi
approved these changes
Feb 18, 2021
antoninbas
approved these changes
Feb 19, 2021
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #1887 +/- ##
=======================================
Coverage ? 26.18%
=======================================
Files ? 184
Lines ? 15843
Branches ? 0
=======================================
Hits ? 4149
Misses ? 11147
Partials ? 547
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/test-conformance |
jianjuns
approved these changes
Feb 19, 2021
jianjuns
pushed a commit
to jianjuns/antrea
that referenced
this pull request
Feb 22, 2021
…ntrea-io#1887) If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside of the new port range are supposed to be deleted. But we face a problem if all rules have to be deleted from NPL chain. In that case we were skipping IPTABLES update - because the length of allNPLPorts in GetPodsAndGenRules function was zero. Removed this length check so that even if all rules have to be deleted, the function addRulesForNPLPorts is executed.
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Mar 11, 2021
…ntrea-io#1887) If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside of the new port range are supposed to be deleted. But we face a problem if all rules have to be deleted from NPL chain. In that case we were skipping IPTABLES update - because the length of allNPLPorts in GetPodsAndGenRules function was zero. Removed this length check so that even if all rules have to be deleted, the function addRulesForNPLPorts is executed.
antoninbas
pushed a commit
that referenced
this pull request
Mar 12, 2021
…1887) If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside of the new port range are supposed to be deleted. But we face a problem if all rules have to be deleted from NPL chain. In that case we were skipping IPTABLES update - because the length of allNPLPorts in GetPodsAndGenRules function was zero. Removed this length check so that even if all rules have to be deleted, the function addRulesForNPLPorts is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside
current port range are supposed to be deleted. But we face a problem if all rules
have to be deleted from NPL chain. In that case we were skipping IPTABLES update -
because length of allNPLPorts in GetPodsAndGenRules function was getting set to zero.
Removed this length check so that even if all rules have to be deleted, the function
addRulesForNPLPorts is executed.