-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the formatting of antctl trace-packet output #1897
Conversation
Transform the "/ovstracing API" response to []byte, and change antctl to output the raw bytes directly for a []byte type response.
Codecov Report
@@ Coverage Diff @@
## main #1897 +/- ##
=======================================
Coverage ? 50.67%
=======================================
Files ? 200
Lines ? 17385
Branches ? 0
=======================================
Hits ? 8810
Misses ? 7451
Partials ? 1124
Flags with carried forward coverage won't be shown. Click here to find out more. |
Will you change |
@lzhecheng : I should mention the reason for this change is because the trace-packet formatting is broken now:
/ovsflows is different - it returns an array of flows, but not a single string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
Transform the "/ovstracing API" response to []byte, and change antctl to output the raw bytes directly for a []byte type response.
Transform the "/ovstracing API" response to []byte, and change antctl to output the raw bytes directly for a []byte type response.
Transform the "/ovstracing API" response to []byte, and change antctl to
output the raw bytes directly for a []byte type response.