Ensure Github workflows use up-to-date base Docker images #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on a CRON job to update the Antrea base images has proven sub-optimal: we sometimes push base images manually which do not match the checked-in Dockerfiles and CI tests run for PRs which update the Dockerfiles ignore these updates (making the tests worthless). We now ensure that Github workflows always build the base images befgore building the Antrea image, thanks to a new helper script. By relying on Docker caching (using the Dockerhub registry as the cache), we ensure that build times are not increased: in the absence of any change, we only add a handful of seconds to the build time. For now, we only update CI jobs run as Github workflow. Once this is merged, we should consider doing the same for Jenkins scripts. We could add support for DOCKER_REGISTRY to the new helper script (hack/build-antrea-ubuntu-all.sh). One question that we could ask now is whether these base images are even necessary: if caching works well, using one large Dockerfile should be just as fast, while simplifying build architecture. This is something we may want to revisit in the future. Maybe using base images only makes sense if we are going to share them across multiple images. See antrea-io#1540
antoninbas
force-pushed
the
ensure-Github-workflows-use-up-to-date-base-images
branch
from
298fd12
to
89f0b30
Compare
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 64.47% 64.54% +0.06%
==========================================
Files 193 193
Lines 16893 16893
==========================================
+ Hits 10892 10903 +11
+ Misses 4837 4830 -7
+ Partials 1164 1160 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
approved these changes
Mar 19, 2021
|
/test-all |
antoninbas
deleted the
ensure-Github-workflows-use-up-to-date-base-images
branch
|
@tnqn thanks, fixed the typo when I squashed |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Mar 30, 2021
In antrea-io#1951 we ensured that the Github workflows would use up-to-date base Docker images by building all images in every run and leveraging Docker caching to reduce build times. With this new change, we do the same thing for Jenkins jobs. See antrea-io#1540
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 2, 2021
In antrea-io#1951 we ensured that the Github workflows would use up-to-date base Docker images by building all images in every run and leveraging Docker caching to reduce build times. With this new change, we do the same thing for Jenkins jobs. See antrea-io#1540
antoninbas
added a commit
that referenced
this pull request
Apr 2, 2021
* Ensure Jenkins CI jobs use up-to-date base Docker images In #1951 we ensured that the Github workflows would use up-to-date base Docker images by building all images in every run and leveraging Docker caching to reduce build times. With this new change, we do the same thing for Jenkins jobs. See #1540 * Increase integration tests timeout * Correct file permissions to enable Docker caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on a CRON job to update the Antrea base images has proven
sub-optimal: we sometimes push base images manually which do not match
the checked-in Dockerfiles and CI tests run for PRs which update the
Dockerfiles ignore these updates (making the tests worthless).
We now ensure that Github workflows always build the base images befgore
building the Antrea image, thanks to a new helper script. By relying on
Docker caching (using the Dockerhub registry as the cache), we ensure
that build times are not increased: in the absence of any change, we
only add a handful of seconds to the build time.
For now, we only update CI jobs run as Github workflow. Once this is
merged, we should consider doing the same for Jenkins scripts. We could
add support for DOCKER_REGISTRY to the new helper script
(hack/build-antrea-ubuntu-all.sh).
One question that we could ask now is whether these base images are even
necessary: if caching works well, using one large Dockerfile should be
just as fast, while simplifying build architecture. This is something we
may want to revisit in the future. Maybe using base images only makes
sense if we are going to share them across multiple images.
See #1540