Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override global testData in e2e tests #1955

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Mar 15, 2021

Otherwise a setup failure would panic and terminate all tests.

For instance: https://jenkins.antrea-ci.rocks/job/antrea-e2e-for-pull-request/2181/console

Otherwise a setup failure would panic and terminate all tests.
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-all

@tnqn
Copy link
Member Author

tnqn commented Mar 16, 2021

@jianjuns @antoninbas thanks for quick review.
/test-e2e

@codecov-io
Copy link

Codecov Report

Merging #1955 (6aa324d) into main (e80ab3b) will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
+ Coverage   64.35%   65.58%   +1.23%     
==========================================
  Files         193      193              
  Lines       16967    16967              
==========================================
+ Hits        10919    11128     +209     
+ Misses       4899     4655     -244     
- Partials     1149     1184      +35     
Flag Coverage Δ
e2e-tests 30.00% <ø> (?)
kind-e2e-tests 55.55% <ø> (+0.34%) ⬆️
unit-tests 41.62% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/cacert_controller.go 55.83% <0.00%> (-10.01%) ⬇️
pkg/controller/networkpolicy/status_controller.go 83.55% <0.00%> (-5.27%) ⬇️
pkg/controller/networkpolicy/tier.go 47.50% <0.00%> (-5.00%) ⬇️
pkg/apiserver/apiserver.go 87.25% <0.00%> (-1.97%) ⬇️
pkg/controller/traceflow/controller.go 69.48% <0.00%> (ø)
...ntroller/networkpolicy/networkpolicy_controller.go 84.25% <0.00%> (+0.12%) ⬆️
pkg/agent/openflow/network_policy.go 75.86% <0.00%> (+0.14%) ⬆️
pkg/agent/cniserver/pod_configuration.go 54.68% <0.00%> (+0.78%) ⬆️
pkg/ovs/openflow/ofctrl_bridge.go 49.01% <0.00%> (+1.18%) ⬆️
pkg/ovs/openflow/ofctrl_builder.go 59.06% <0.00%> (+1.34%) ⬆️
... and 10 more

@tnqn
Copy link
Member Author

tnqn commented Mar 16, 2021

The jenkins e2e test failed because of #1956, which was not related to this patch.
As the patch is simple enough and all e2e tests on kind clusters have succeeded, skip jenkins e2e test.
/skip-e2e

@tnqn tnqn merged commit 020946f into antrea-io:main Mar 16, 2021
@tnqn tnqn deleted the test-panic branch March 16, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants