Add agent API and antctl command to dump OVS groups #1984
Conversation
| @@ -87,7 +87,7 @@ func dumpMatchedGroups(aq agentquerier.AgentQuerier, groupIDs []binding.GroupIDT | |||
| // number is invalid). | |||
| func getTableFlows(aq agentquerier.AgentQuerier, table string) ([]Response, error) { | |||
There was a problem hiding this comment.
not introduced by this PR, but do you think you could rename table to tables to match the new getGroups?
pkg/antctl/antctl.go
Outdated
| @@ -330,6 +334,11 @@ var CommandList = &commandList{ | |||
| usage: "Comma separated Antrea OVS flow table names or numbers", | |||
| shorthand: "T", | |||
| }, | |||
| { | |||
| name: "groups", | |||
| usage: "Comma separated OVS group IDs. Use 'all' for dumping all groups", | |||
There was a problem hiding this comment.
| usage: "Comma separated OVS group IDs. Use 'all' for dumping all groups", | |
| usage: "Comma separated OVS group IDs. Use 'all' to dump all groups", |
pkg/ovs/ovsctl/ofctl.go
Outdated
| // There seems a bug in ovs-ofctl that dump-groups always returns all | ||
| // the groups when using Openflow13, even when the group ID is provided. | ||
| // As a workaround, we do not specify Openflow13 to run the command. |
There was a problem hiding this comment.
Unrelated to this PR as well, but this comment looks incorrect. As per the documentation for dump-groups:
Only OpenFlow 1.5 and later support dumping a specific group.
Earlier versions of OpenFlow always dump all groups.
When we omit the OpenFlow version, it will default to OpenFlow10, but also enable the Nicira extensions apparently, which support dumping a single group. When specifying OpenFlow13 explicitly, it will not enable these extensions and as per the manual it does not support dumping a single group. As for specifying OpenFlow15, we do not enable this protocol on the bridge at the moment. So there is no bug in ovs-ofctl.
There was a problem hiding this comment.
Thanks for figuring this out! Updated the comments.
Still think ovs-ofctl should at least provide some hints when a group ID is specified with a OpenFlow version does not support that.
jianjuns
force-pushed
the
dump-group
branch
2 times, most recently
from
5afa9d7
to
6799d0a
Compare
|
/test-all |
|
/test-all |
|
/test-all |
antctl get of -G 1,10,2
FLOW
group_id=1,type=select,bucket=bucket_id:0,weight:100,actions=load:0xac640003->NXM_NX_REG3[],load:0x35->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19],resubmit(,42),bucket=bucket_id:1,weight:100,actions=load:0xac640002->NXM_NX_REG3[],load:0x35->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19],resubmit(,42)
group_id=2,type=select,bucket=bucket_id:0,weight:100,actions=load:0xac640003->NXM_NX_REG3[],load:0x23c1->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19],resubmit(,42),bucket=bucket_id:1,weight:100,actions=load:0xac640002->NXM_NX_REG3[],load:0x23c1->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19],resubmit(,42)