Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARM installation instructions for v1.0 release #1994

Conversation

antoninbas
Copy link
Contributor

Now that antrea/antrea-ubuntu is a manifest list / multi-arch image,
there is no longer a need for different installation instructions for
clusters which include ARM Nodes.

Now that antrea/antrea-ubuntu is a manifest list / multi-arch image,
there is no longer a need for different installation instructions for
clusters which include ARM Nodes.
@antoninbas antoninbas added kind/documentation Categorizes issue or PR as related to a documentation. and removed cla-not-required labels Mar 25, 2021
@antoninbas antoninbas added this to the Antrea v0.14.0 release milestone Mar 25, 2021

Note that while we do run a subset of the Kubernetes conformance tests on both
the arm/v7 and arm64 Docker images (using [k3s](https://k3s.io/) as the
Kubernetes distribution), our testing is not as thorough as for the amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not as thorough as that for the amd64?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure

these [installation instructions](arm-support.md).
Starting with v1.0, Antrea supports arm64 and arm/v7 Nodes. The installation
instructions do not change when some (or all) Linux Nodes in a cluster use an
ARM architecture: the `antrea/antrea-ubuntu` Docker image is actually a manifest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes me some seconds to understand the sentence. Could we add more contexts here, like: the same Antrea deployment YAML can be used, etc.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it a bit, let me know if you have something different in mind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 958898f into antrea-io:main Apr 7, 2021
@antoninbas antoninbas deleted the update-arm-installation-instructions-for-v1.0-release branch April 7, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants