-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial issue templates #2
Conversation
00ffcd5
to
effc680
Compare
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
**Versions:** | ||
Please specify the versions of following systems: | ||
- Antrea version (Docker image tag) | ||
- Kubernetes version (use `kubectl version`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl version might not necessarily the same as kube-apiserver... is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl versions
gives both version numbers (client & server). I updated this section so PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good.
effc680
to
9b84ec5
Compare
Use YEAR to replace 2019 in header templates: license_header.raw.txt and license_header.go.txt. Command mockgen does not automatically replace variable YEAR with current year like others do, e.g. client-gen. Added check in update-codegen-dockerized.sh: reset file change if it is introduced by year change. 1. filter changed files by 1 added line and 1 deleted line 2. check if diff result contains "Copyright YEAR Antrea Authors" line 3. reset the file if #2 returns true
(cherry picked from commit dac13ee)
* Fix a few nits. * Make IPTablesRules private.
* Fix a few nits. * Make IPTablesRules private.
* Fix a few nits. * Make IPTablesRules private.
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
add `// +genclient` mark so we can use *-gen tools to generate client codes automatically. Signed-off-by: Lan Luo <[email protected]>
No description provided.