Fix syncHandler issue in status_controller #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
approved these changes
Apr 7, 2021
It seems that there is no UT covering this specific case |
Codecov Report
@@ Coverage Diff @@
## main #2036 +/- ##
===========================================
+ Coverage 41.69% 55.64% +13.95%
===========================================
Files 127 265 +138
Lines 15844 19773 +3929
===========================================
+ Hits 6606 11003 +4397
+ Misses 8684 7603 -1081
- Partials 554 1167 +613
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
|
/test-e2e |
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
antoninbas
pushed a commit
that referenced
this pull request
Apr 30, 2021
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
antoninbas
pushed a commit
that referenced
this pull request
May 1, 2021
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
May 1, 2021
antoninbas
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue when the status_controller tries to update NetworkPolicyStatus to Pending, it always assumes the policy is Antrea NetworkPolicy instead of Antrea ClusterNetworkPolicy. This will result in failures in status updates which are visible at lowest klog verbose level.