Fix Network Policy logging on Windows Nodes #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes antrea-io#2050
|
/test-all |
jianjuns
previously approved these changes
Apr 8, 2021
Codecov Report
@@ Coverage Diff @@
## main #2052 +/- ##
===========================================
+ Coverage 41.41% 64.84% +23.43%
===========================================
Files 131 270 +139
Lines 16437 20366 +3929
===========================================
+ Hits 6807 13206 +6399
+ Misses 9049 5823 -3226
- Partials 581 1337 +756
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
|
/test-windows-networkpolicy |
|
/test-networkpolicy |
|
/test-all |
|
/test-e2e |
tnqn
previously approved these changes
Apr 9, 2021
pkg/util/logdir/logdir.go
Outdated
| if logDirFlag == nil { | ||
| logDir = antreaWellKnownLogDir | ||
| } else if len(logDirFlag.Value.String()) == 0 { | ||
| logDir = logDirFlag.DefValue |
There was a problem hiding this comment.
Out of curiosity, what's the default value?
There was a problem hiding this comment.
That's a good question. I copied the code from support bundle and it seems wrong now. DefValue will be an empty string, but it should be os.TempDir(). I will wait for the tests to pass then fix before I merge (this code path is not actually used by any test).
|
skipping tests because they are not affected by the last commit |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes antrea-io#2050
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes antrea-io#2050
antoninbas
added a commit
that referenced
this pull request
Apr 30, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes #2050
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes antrea-io#2050
antoninbas
added a commit
that referenced
this pull request
May 1, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes #2050
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
May 1, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes antrea-io#2050
antoninbas
added a commit
that referenced
this pull request
May 3, 2021
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir flag. We unify the approach for support bundle and Network Policy logging. Fixes #2050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows Nodes the path should be /k/antrea/logs/networkpolicy/np.log
and not /var/log/antrea/networkpolicy/np.log, as decided by the log_dir
flag.
We unify the approach for support bundle and Network Policy logging.
Fixes #2050