Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update brew install commands #2074

Merged
merged 1 commit into from
Apr 12, 2021
Merged

update brew install commands #2074

merged 1 commit into from
Apr 12, 2021

Conversation

RayBB
Copy link
Contributor

@RayBB RayBB commented Apr 11, 2021

brew recently disabled brew cask install and switch to brew install --cask.

This PR updates the readme to use the new command.

You can see others talking about the change here: ansible-collections/community.general#1524

@vmwclabot
Copy link

@RayBB, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@tnqn
Copy link
Member

tnqn commented Apr 12, 2021

@RayBB thanks for the PR! Could you sign the contributor license agreement so we can merge it?

@tnqn tnqn requested a review from antoninbas April 12, 2021 09:35
@tnqn
Copy link
Member

tnqn commented Apr 12, 2021

Just saw CLA verification passed, please ignore if you have signed it.

antoninbas
antoninbas approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas added kind/documentation Categorizes issue or PR as related to a documentation. area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. labels Apr 12, 2021
@antoninbas antoninbas merged commit de29b10 into antrea-io:main Apr 12, 2021
@vmwclabot
Copy link

@RayBB, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RayBB @vmwclabot @tnqn @antoninbas