-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeSelector for FlowAggregator and ELK Pods #2087
Add nodeSelector for FlowAggregator and ELK Pods #2087
Conversation
When using the FlowAggregator or the ELK reference stack on a cluster with ARM and Windows Nodes, Pods should be scheduled on Linux AMD64 Nodes. For the FlowAggregator, we may consider providing a multi-arch Docker manifest with support for ARM achitectures, like we do for the the Antrea image.
Codecov Report
@@ Coverage Diff @@
## main #2087 +/- ##
==========================================
- Coverage 60.97% 60.88% -0.10%
==========================================
Files 270 270
Lines 20366 20366
==========================================
- Hits 12418 12399 -19
- Misses 6649 6672 +23
+ Partials 1299 1295 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, multi-arch flow aggregator manifest sounds good. We should open an issue.
In addition, for the flow aggregator, I think there is no tight requirement for the node to have Linux OS and it should be able to run on windows nodes if we can put together a proper image. Not very familiar with Windows deployments. Do you agree? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
/test-e2e |
/test-e2e |
Yes, we could in theory but I don't think there is an advantage in doing so at the moment. Windows clusters will typically have Linux Nodes as well. |
Yup, I read that one of the requirements for Kubernetes clusters with Windows nodes is to have control plane node on Linux. |
When using the FlowAggregator or the ELK reference stack on a cluster
with ARM and Windows Nodes, Pods should be scheduled on Linux AMD64
Nodes.
For the FlowAggregator, we may consider providing a multi-arch Docker
manifest with support for ARM achitectures, like we do for the the
Antrea image.