Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector for FlowAggregator and ELK Pods #2087

Conversation

antoninbas
Copy link
Contributor

When using the FlowAggregator or the ELK reference stack on a cluster
with ARM and Windows Nodes, Pods should be scheduled on Linux AMD64
Nodes.

For the FlowAggregator, we may consider providing a multi-arch Docker
manifest with support for ARM achitectures, like we do for the the
Antrea image.

When using the FlowAggregator or the ELK reference stack on a cluster
with ARM and Windows Nodes, Pods should be scheduled on Linux AMD64
Nodes.

For the FlowAggregator, we may consider providing a multi-arch Docker
manifest with support for ARM achitectures, like we do for the the
Antrea image.
@codecov-io
Copy link

codecov-io commented Apr 13, 2021

Codecov Report

Merging #2087 (57cc3e8) into main (b118f2d) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
- Coverage   60.97%   60.88%   -0.10%     
==========================================
  Files         270      270              
  Lines       20366    20366              
==========================================
- Hits        12418    12399      -19     
- Misses       6649     6672      +23     
+ Partials     1299     1295       -4     
Flag Coverage Δ
kind-e2e-tests 51.54% <ø> (-0.10%) ⬇️
unit-tests 41.35% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/openflow/pipeline.go 67.70% <0.00%> (-2.16%) ⬇️
pkg/agent/openflow/client.go 59.04% <0.00%> (-0.80%) ⬇️
pkg/agent/agent.go 47.48% <0.00%> (+0.47%) ⬆️
pkg/agent/route/route_linux.go 42.44% <0.00%> (+0.58%) ⬆️
...ntroller/networkpolicy/networkpolicy_controller.go 71.10% <0.00%> (+0.97%) ⬆️
pkg/apiserver/storage/ram/watch.go 94.23% <0.00%> (+3.84%) ⬆️

Copy link
Member

@srikartati srikartati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, multi-arch flow aggregator manifest sounds good. We should open an issue.

@srikartati
Copy link
Member

srikartati commented Apr 13, 2021

Yes, multi-arch flow aggregator manifest sounds good. We should open an issue.

In addition, for the flow aggregator, I think there is no tight requirement for the node to have Linux OS and it should be able to run on windows nodes if we can put together a proper image. Not very familiar with Windows deployments. Do you agree?

Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-e2e

@antoninbas
Copy link
Contributor Author

/test-e2e

@antoninbas antoninbas merged commit 419e171 into antrea-io:main Apr 16, 2021
@antoninbas antoninbas deleted the add-nodeSelector-for-flow-aggregator-and-elk-pods branch April 16, 2021 15:44
@antoninbas
Copy link
Contributor Author

In addition, for the flow aggregator, I think there is no tight requirement for the node to have Linux OS and it should be able to run on windows nodes if we can put together a proper image. Not very familiar with Windows deployments. Do you agree?

Yes, we could in theory but I don't think there is an advantage in doing so at the moment. Windows clusters will typically have Linux Nodes as well.

@srikartati
Copy link
Member

Yes, we could in theory but I don't think there is an advantage in doing so at the moment. Windows clusters will typically have Linux Nodes as well.

Yup, I read that one of the requirements for Kubernetes clusters with Windows nodes is to have control plane node on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants