-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARP spoofing guard for host gateway port #210
Conversation
Thanks for your PR. The following commands are available:
|
Add ARP spoof guard flow entry after host gateway interface is created.
/test-e2e |
I personally feel no need to restrict the default namespace traffic. Anyway, you could not control all interfaces on the node. |
@antoninbas and I have an offline discussion about it, and we thought if the ARP reply sent from gw0 is using a fake MAC, later Openflow entries might not work, especially for the traffic that needs to be forwarded by host gateway. Technically, the MAC/IP address could be changed when the packets enters OVS from gw0 interface. |
You see if a Pod could send raw packets from a host interface, it could do many attacks, like it could even send VXLAN packets from a physical interface. And such containers should not be viewed as an application container, but more like a local daemon like antrea-agent. |
@jianjuns I agree about your statement. However, ARP spoofing is pretty bad IMO since it can mess up the networking for other Pods and that change actually prevents that it seems. So unless there is a downside to this change I am not seeing, I suggest we merge it. |
@antoninbas @wenyingd : I just do not like to add unnecessary flows and do not like to restrict host interface/traffic. But for this one I do not have a strong opinion. As you said there is no hard either (not sure if there could be cases that we want to manually bind another IP to the gateway interface though, of course for testing purposes only). |
Add ARP spoof guard flow entry after host gateway interface is created.
Fixes #200