-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the annotations of some structs in pkg/api #2164
Conversation
@heshengyuan1311, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heshengyuan1311. Do you happen to have the link of "golang struct annotation specification" about this so we can reference to it when reviewing similar changes?
Codecov Report
@@ Coverage Diff @@
## main #2164 +/- ##
===========================================
- Coverage 61.20% 41.33% -19.87%
===========================================
Files 270 132 -138
Lines 20478 16539 -3939
===========================================
- Hits 12533 6837 -5696
- Misses 6646 9115 +2469
+ Partials 1299 587 -712
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for reviewing. I fix these annotations beacuse of the rule of godoc. https://blog.golang.org/godoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I confirmed that the current documentation doesn't render properly because of the missing empty lines. I have also confirmed that K8s always leaves an empty line between code generation directive and actual type comments.
/skip-all |
@heshengyuan1311 CI is failing with the following error:
Can you run |
Thanks for reviewing,
repushed the commit with codegen. |
/skip-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for regenerating the code - let's see if the CI job succeeds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@heshengyuan1311, VMware has approved your signed contributor license agreement. |
Fixed some annotations that violated the golang struct annotation specification.