Add dual-stack service support #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2207 +/- ##
==========================================
+ Coverage 61.63% 65.14% +3.51%
==========================================
Files 273 274 +1
Lines 20673 20830 +157
==========================================
+ Hits 12742 13570 +828
+ Misses 6594 5880 -714
- Partials 1337 1380 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
May 26, 2021
There was a problem hiding this comment.
one small comment on testing, otherwise LGTM (I didn't really review the files under third_party in details since they are copied from upstream).
@jianjuns @tnqn do you think we should try to merge this before the Antrea v1.1 release since dual-stack services are Beta (enabled by default) in K8s v1.21?
|
Yes, agreed would be nice to include this one in 1.1. And the PR looks good to me. |
Kubernetes 1.21 supports dual-stack services. This is a following up PR of antrea-io#1973. This PR updates third_party/proxy package based on the recent changes of kubernetes v1.21.0. Unit test for dual-stack service is added. Signed-off-by: Xu Liu <[email protected]>
|
/test-all |
antoninbas
approved these changes
May 27, 2021
|
/test-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the following PR separated from #1973.
Kubernetes 1.21 add support for dual-stack services. To support this we need to update
third_party/proxypkg to reflect the recent changes in the upstream kubernetes repo. Unit tests are added accordingly.